Skip to content

Conversation

@fregante
Copy link
Member

@fregante fregante commented Jun 6, 2017

Related to #439

Definitions

Unsafe assignment to innerHTML

Warning: Due to both security and performance concerns, this may not be set using dynamic values which have not been adequately sanitized. This can lead to security issues or fairly serious performance degradation.

"storage.local" can cause issues when loaded temporarily

Warning: This API can cause issues when loaded temporarily using about:debugging in Firefox unless you specify applications > gecko > id in the manifest. Please see: https://mzl.la/2hizK4a for more.

@fregante fregante requested a review from jgierer12 June 6, 2017 04:13
@fregante fregante force-pushed the fix-unsafe-warnings branch from c90fab1 to 299072c Compare June 6, 2017 04:54
@fregante fregante changed the title Fix AMO review warnings Fix AMO review warnings (WIP) Jun 6, 2017
@fregante fregante force-pushed the fix-unsafe-warnings branch from 299072c to a3907d9 Compare June 6, 2017 08:32
@fregante fregante changed the title Fix AMO review warnings (WIP) Fix AMO review warnings Jun 6, 2017
@fregante fregante merged commit fe95ed2 into master Jun 6, 2017
@fregante fregante deleted the fix-unsafe-warnings branch June 6, 2017 08:34
@derimagia
Copy link

"application" existing in the manifest for chrome is throwing a warning, is this okay?

1ism2fx

@fregante
Copy link
Member Author

fregante commented Jun 16, 2017

Yeah, this is Google Chrome still not being a good citizen towards Mozilla's WebExtension effort: https://bugs.chromium.org/p/chromium/issues/detail?id=677855

The "applications" key only seems to be supported by firefox. It's not supported by Chrome so showing a warning is valid.

🙄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants