Skip to content

Simplify removeDiffSigns #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sindresorhus merged 4 commits into from
Jun 16, 2017
Merged

Simplify removeDiffSigns #469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5be2f7e
Simplify removeDiffSigns + fix copy-paste whitespace
fregante Jun 6, 2017
4c4f492
Avoid jump caused by space removal
fregante Jun 6, 2017
3adaead
Only add signs once the removal was successful
fregante Jun 6, 2017
2ca4178
Add support for Firefox
fregante Jun 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions extension/content.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,8 +555,8 @@ hidden content area created to increase hover target
}

/* +/- pseudo elements on diffs */
td.blob-code.blob-code-addition:before,
td.blob-code.blob-code-deletion:before {
.refined-github-diff-signs .blob-code-addition:before,
.refined-github-diff-signs .blob-code-deletion:before {
display: inline-block;
position: absolute;
top: 1px;
Expand All @@ -566,14 +566,26 @@ td.blob-code.blob-code-deletion:before {
color: rgba(0, 0, 0, 0.3);
}

td.blob-code.blob-code-addition:before {
.refined-github-diff-signs .blob-code-addition:before {
content: '+';
}

td.blob-code.blob-code-deletion:before {
.refined-github-diff-signs .blob-code-deletion:before {
content: '-';
}

/* prevent copy of ghost whitespace where supported (#317) */
.refined-github-diff-signs .add-line-comment {
-moz-user-select: none;
user-select: none;
}

/* restore removed space with unselectable one*/
.refined-github-diff-signs .blob-code-inner:before {
content: ' ' !important;
user-select: none;
}

/* remove "pro tip!" box on profile page (appears when name isn't set) */
.new-user-avatar-cta {
display: none !important;
Expand Down
11 changes: 5 additions & 6 deletions src/content.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,12 +271,11 @@ function addPatchDiffLinks() {
}

function removeDiffSigns() {
$('.blob-code-addition, .blob-code-deletion')
.find('.blob-code-inner:not(.refined-github-diff-signs)')
.each((index, element) => {
const $element = $(element);
$element.html(` ${$element.html().slice(1)}`);
$element.addClass('refined-github-diff-signs');
$('.diff-table:not(.refined-github-diff-signs)')
.addClass('refined-github-diff-signs')
.find('.blob-code-inner')
.each((index, el) => {
el.firstChild.textContent = el.firstChild.textContent.slice(1);
});
}

Expand Down