Simplify removeDiffSigns #469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I'm still getting the spaces described in #453 (comment) |
Member
Author
|
Can you give me a link and a screenshot of the github.com page you're selecting? I can't reproduce |
Member
|
I'm just selecting some code in the diff view of this PR.
|
Member
Author
|
Ah true, I must have broken it while tweaking it. |
fregante
force-pushed
the
diff-whitespace-bug
branch
from
596fe95 to
2ca4178
Compare
Member
Author
|
Surprise! In Chrome, I'll probably end up removing the whitespace-only Alternatively, the rule I think this PR can be merged for now (without closing #317), at least it's lighter than before and it works in Firefox. |
fregante
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The space mentioned by #317 is:
<button>;now made non-selectableReplaces #453