Restore toggle-files-button#4559
Merged
fregante merged 5 commits intorefined-github:mainfrom Jul 16, 2021
cheap-glitch:fix-toggle-files-button
Merged
Restore toggle-files-button#4559fregante merged 5 commits intorefined-github:mainfrom cheap-glitch:fix-toggle-files-button
toggle-files-button#4559fregante merged 5 commits intorefined-github:mainfrom
cheap-glitch:fix-toggle-files-button
Conversation
cheap-glitch
commented
Jul 12, 2021
|
|
||
| function addButton(): void { | ||
| const filesHeader = select('.Box-header--blue .Details > :last-child > ul'); | ||
| const filesHeader = select('.Box-header .Details > :last-child > ul'); |
Contributor
Author
There was a problem hiding this comment.
Sadly I don't think there's much we can do about this brittle selector.
- replace
.Box-headerwith.hx_commit-tease(it seems to be a unique class name on the relevant pages) - use the select + closest strategy, maybe with
[title^="View all commits by"]to reach the.Detailsdirectly
fregante
changed the title
toggle-files-buttontoggle-files-button
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4547
Test URLs
Screenshot