Add comment-on-draft-pr-indicator feature
#4541
Conversation
- Followed all suggestions by yakov116 and fregante - Updated the feature screenshot to include the Files tab
Co-authored-by: Federico Brigante <me@fregante.com>
Rename the feature
fregante
force-pushed
the
comment-on-draft-pr-indicator
branch
from
6df91d6 to
6a3f2af
Compare
fregante
changed the title
comment-to-draft-pr-button featurecomment-on-draft-pr-indicator feature
|
@yakov116 you mentioned the need for |
yakov116
left a comment
yakov116
left a comment
There was a problem hiding this comment.
Does not stay after commenting. I think just doing deduplicate false will work
|
I just want to clarify one thing: |
|
The "Close with comment | Comment" part is a partial that is updated independently of new comments. I used a node removal listener to track its replacement
|
|
|
||
| export default async function onReplacedElement(selector: string, callback: VoidCallback): Promise<void> { | ||
| export default async function onReplacedElement( | ||
| selector: string, |
There was a problem hiding this comment.
Shouldn't this be changed to an object? Isn't it a boolean trap?
There was a problem hiding this comment.
There was a problem hiding this comment.
Oh you meant to comment on the callNow line since there's no boolean here 😃
Good point, changing
There was a problem hiding this comment.
Sorry I was on mobile and selected the wrong line.
3 participants
Closes #3857
Based on #4520
Test
Any draft PR
fregante/webext-detect#2
https://github.com/fregante/webext-detect-page/pull/2/files
Screenshots