Small bug fixes #4444
Small bug fixes #4444
Conversation
|
#4444 nice. |
|
Can you also drop the comment at the top of refined-github.ts since we’re going to use hotfixes from now on? |
|
What's b45b4bb? It's not mentioned in the post and there are no test links or bug issues |
I marked it as draft. My computer broke (son dropped it 😢), I have to redo the whole first post. Will do when I can. |
|
That checks if the date of the comment is after or before the last commit. The selector needed to be updated. |
Can happen if the projects is no enable at all
| async function hideProjects(): Promise<void> { | ||
| if (!await hasProjects()) { | ||
| (await elementReady('[data-hotkey="p"]'))!.parentElement!.remove(); | ||
| (await elementReady('[data-hotkey="p"]'))?.parentElement!.remove(); |
There was a problem hiding this comment.
Line 57 exactly checks for projects. If we get to line 58, there should not be any projects.
There was a problem hiding this comment.
hmm I will double check what's going on
There was a problem hiding this comment.
Line 57 exactly checks for projects.
Correct but it does not check if the projects dropdown exists.
I have the error on https://github.com/download-directory/download-directory.github.io/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3Abug
There was a problem hiding this comment.
There was a problem hiding this comment.
Let's merge hideProjects and hasProjects into something that makes more sense. Currently the condition is "has projects" while it tries to be "should it hide the section"
Why are we even checking for projects if there's no sidebar section to hide at all?
example url that should not show the bar |
Will get the last 100
This reverts commit 9745099.
I'm confused, why should that page not show the bar?
|
| // eslint-disable-next-line import/prefer-default-export | ||
| export function getCommitHash(commit: HTMLElement): string { | ||
| return commit.querySelector('a[href]')!.pathname.split('/').pop()!; | ||
| return commit.querySelector('a[href]:not(.js-issue-link)')!.pathname.split('/').pop()!; |
There was a problem hiding this comment.
Does not work? PRs also have the same class
There was a problem hiding this comment.
PR's? We are catching the wrong link.
From now on I will open an issue for each and thing I want to fix.
There was a problem hiding this comment.
There was a problem hiding this comment.
From now on I will open an issue for each and thing I want to fix.
If you're writing a PR, you can include the details in the PR itself to save some time
|
Thanks for the many bug fixes but it's best to open multiple PRs, following the template. If I can't see the bug in a link, in a screenshot, and/or in a issue, I'm reverting. |
Please look at the first post post.... |
|
Where are the screenshots? I don’t know what “Fix duplication in show-whitespace” refers to. No screenshot of bug, no screenshot of fix, no link to any issues for most fixes here. We had discussed that specific bug somewhere but that doesn’t mean everyone reading knows; I’m not sure I remember what the bug was specifically. Follow the template, it’s just easier to understand and review. I don’t know why I have to explain how to follow a template in every PR you open. |
2 participants
Fixes #3945
Make features faster closes #3673
list-prs-for-filefasterdefault-branch-buttonfasterconvert-release-to-draftfastercomment-time-machine-linksdate check - https://github.com/sindresorhus/refined-github/blob/main/source/features/action-used-by-link.tsx?rgh-link-date=2021-04-28T07%3A12%3A39Zshow-associated-branch-prs-on-forkdisplay textshow-associated-branch-prs-on-fork- Will get the last 100mark-merge-commits-in-list- https://github.com/pixiebrix/pixiebrix-extension/commits/main