Skip to content

Fix dim-bots with multiple PR labels #4355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yakov116 merged 4 commits into from
May 16, 2021
Merged

Fix dim-bots with multiple PR labels #4355

yakov116 merged 4 commits into from
May 16, 2021

Conversation

@agaudreault
Copy link
Contributor

@agaudreault agaudreault commented May 12, 2021 •
edited
Loading

Closes #4354
Fixes a regression from #3921 causing the PRs with more than just the bot label not to be dimmed anymore.

Test URLs

  1. Create a pull request with a bot label and any other one.
  2. Browse to https://github.com/pulls

Screenshot

normal hover
Before image N/A
After image image

@yakov116
Copy link
Member

yakov116 commented May 12, 2021

Thanks for the PR
Please fill out the entire template

@agaudreault agaudreault marked this pull request as ready for review May 12, 2021 22:56
@agaudreault
Copy link
Contributor Author

agaudreault commented May 12, 2021 •
edited
Loading

@yakov116 I am not very sure about the selector syntax, but while I was testing, I found out that
'.labels [href$="label%3Abot"]' selector will not work if the PR has more than one label.

Do you know the syntax for labels.contains('bot') so I could fix that at the same time ? It seems caused by #3921

Edit: Fixed

fregante
fregante reviewed May 13, 2021
View reviewed changes
@fregante fregante changed the title feat(dim-bot): add to Pull Request list page Enable dim-bots on global PR list page May 13, 2021
@agaudreault agaudreault changed the title Enable dim-bots on global PR list page Fix dim-bots with multiple PR labels May 13, 2021
@agaudreault agaudreault requested a review from fregante May 13, 2021 14:06
@yakov116 yakov116 added the bug label May 13, 2021
yakov116
yakov116 reviewed May 13, 2021
View reviewed changes
@agaudreault @yakov116
Update source/features/dim-bots.tsx
27e1ca0 
Co-authored-by: yakov116 <16872793+yakov116@users.noreply.github.com>
@agaudreault agaudreault requested a review from yakov116 May 13, 2021 20:46
@yakov116
Copy link
Member

yakov116 commented May 14, 2021

I found it on https://github.com/pulls?page=2&q=archived%3Afalse+commenter%3Aagaudreault-jive+sort%3Aupdated-desc

yakov116
yakov116 approved these changes May 14, 2021
View reviewed changes
Copy link
Member

@yakov116 yakov116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yakov116 yakov116 merged commit 73fa11a into refined-github:main May 16, 2021
@yakov116
Copy link
Member

yakov116 commented May 16, 2021

Thanks @agaudreault-jive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yakov116 yakov116 yakov116 approved these changes

@fregante fregante Awaiting requested review from fregante

Assignees

No one assigned

Labels

bug

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dim bots in user pull request view

3 participants

@agaudreault @yakov116 @fregante