Improve spacing of PR header buttons #4281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
We just need to add a single space character, unconditionally. Mr-1 is not exactly the same I think |
Member
Author
|
Does it work? I tried and not luck 😅
"Open with" button has a 4px (same as .mr-1) left margin, unfortunately it's inside so they won't overlap. |
fregante
reviewed
Apr 26, 2021
fregante
changed the title
view-last-pr-deployment on editable PRsview-last-pr-deployment: Fix spacing on editable PRs
Member
Author
|
I added new screenshots in PR description. |
Member
|
If you’re going that route, we only need a CSS rule, no extra classes. I think left:8px and right:4px |
Member
Author
|
That won't work on non-editable PR, the spacing will be 4px from "Open With". |
fregante
changed the title
view-last-pr-deployment: Fix spacing on editable PRs
Member
💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4277
Test URLs
See #4089
Screenshot