Repository navigation
Conversation
|
|
|
OK from my finding, they have a unique DOM. Its a regular user with some added select dropdowns. |
This reverts commit a50fdb1.
2821c70 to
df6b8de
Compare
Full access
Triage access
I think the issue here is specifically because the “Assign yourself” button is missing from the Triager’s sidebar and therefore the “children count” is zero. Since the next condition selects this element, we can use that instead of this additional select. This also allows for a slight improvement of the whole if/else |
|
I lost you here, I am getting lost between this and that |
|
I am going to close this as this feature needs a to be fixed anyways |
| const assignees = select('.js-issue-assignees')!; | ||
| if (assignees.children.length === 0) { | ||
| // `#assignees-select-menu` check is for collaborators with only "triage access" #4238 | ||
| if (assignees.children.length === 0 && !select('#assignees-select-menu')) { |
There was a problem hiding this comment.
What I meant in my previous comment is that #assignees-select-menu covers both cases, so assignees.children.length === 0 is a redundant check.
The same exact thing happened in #4336 (comment): A new selector/check was added instead of replacing the existing one. #4327 is the same, in a way.
Fixes #4238
Test URLs
I tested on download-directory/download-directory.github.io#37
Screenshot