fit-textareas: Improve performance
#4222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
changed the title
element-ready and fit-textareafit-textareas performance
Member
|
@fregante can we merge this and see if we have any issues? |
fregante
changed the title
fit-textareas performancefit-textareas: Improve performance
Member
Author
|
Tested in Chrome and it seems to behave correctly there at least |
Merged
fregante
added a commit
that referenced
this pull request
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows sindresorhus/element-ready#35 and fregante/fit-textarea#15
fit-textareawould need some testing to ensure it works correctly, even if it had some automated browser tests.Hopefully this update fixes the terrible performance this feature has in Safari. I had to disable it in PRs because it would cause each character to appear on screen after 700ms… each.
On my new computer this is less noticeable, but still I can feel it