Repository navigation
Fix more-dropdown removing repo tabs container - #4168
Merged
Merged
Conversation
sharkykh
marked this pull request as ready for review
March 29, 2021 17:21
Co-authored-by: Florent <cheap.glitch@gmail.com>
Member
|
Also seeing that now with more-dropdown disabled |
Member
Thats why its called |
Member
|
Using #4119 looks like its |
Member
|
Is that due to RG? |
Member
|
#4169 fixed the issue. Merged |
Member
|
Thanks for fixing this! Too bad I wasn’t at the computer today 🤷♂️ happens every time, it seems. I kept the issue open for visibility |
fregante
reviewed
Mar 31, 2021
| } | ||
|
|
||
| tabItem!.parentElement!.remove(); | ||
| tabItem!.closest('.UnderlineNav-item')!.remove(); |
Member
There was a problem hiding this comment.
They changed it again. Does this work? I'm still AFK. Please someone send a PR before v21.4.1 is released
Suggested change
| tabItem!.closest('.UnderlineNav-item')!.remove(); | |
| tabItem!.closest('.UnderlineNav-item, li')!.remove(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #4166
Looks like GitHub changed their layout:
The
[data-tab-item$="${id}"]selector now points to the tab anchor/link.