Skip to content

Fix more-dropdown removing repo tabs container - #4168

Merged
fregante merged 3 commits into
refined-github:mainfrom
sharkykh:fix-more-dropdown
Mar 30, 2021
Merged

fregante merged 3 commits into
refined-github:mainfrom
sharkykh:fix-more-dropdown

Conversation

@sharkykh

@sharkykh sharkykh commented Mar 29, 2021 •

Copy link
Copy Markdown
Contributor

Fixes #4166

Looks like GitHub changed their layout:
The [data-tab-item$="${id}"] selector now points to the tab anchor/link.

image

@sharkykh
sharkykh marked this pull request as ready for review March 29, 2021 17:21
Comment thread source/features/more-dropdown.tsx Resolved
Co-authored-by: Florent <cheap.glitch@gmail.com>
@yakov116

Copy link
Copy Markdown
Member

can someone look into why we are seeing double before I merge this?

image

@j-f1

j-f1 commented Mar 30, 2021

Copy link
Copy Markdown

Also seeing that now with more-dropdown disabled

@yakov116

Copy link
Copy Markdown
Member

Also seeing that now with more-dropdown disabled

Thats why its called more-dropdown:) When disabled you get more JK

@yakov116

Copy link
Copy Markdown
Member

Using #4119 looks like its bugs-tab

@fregante

Copy link
Copy Markdown
Member

Is that due to RG?

@yakov116

Copy link
Copy Markdown
Member

#4169 fixed the issue. Merged

@yakov116 yakov116 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@yakov116 yakov116 added the bug label Mar 30, 2021
@fregante

fregante commented Mar 30, 2021 •

Copy link
Copy Markdown
Member

Thanks for fixing this! Too bad I wasn’t at the computer today 🤷‍♂️ happens every time, it seems.

I kept the issue open for visibility

@fregante
fregante merged commit 00ddcbb into refined-github:main Mar 30, 2021
@sharkykh
sharkykh deleted the fix-more-dropdown branch March 30, 2021 09:43
}

tabItem!.parentElement!.remove();
tabItem!.closest('.UnderlineNav-item')!.remove();

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They changed it again. Does this work? I'm still AFK. Please someone send a PR before v21.4.1 is released

Suggested change
tabItem!.closest('.UnderlineNav-item')!.remove();
tabItem!.closest('.UnderlineNav-item, li')!.remove();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

5 participants