-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Restore rgh-linkify-features and linkify-code in titles
#4136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rgh-linkify-features in titlesrgh-linkify-features and linkify-code in titles
rgh-linkify-features and linkify-code in titlesrgh-linkify-features and linkify-code in titles
fregante
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Untested but LGTM
rgh-linkify-features and linkify-code in titlesrgh-linkify-features and linkify-code in titles
rgh-linkify-features and linkify-code in titles rgh-linkify-features and linkify-code in titles
rgh-linkify-features and linkify-code in titles rgh-linkify-features and linkify-code in titles
rgh-linkify-features and linkify-code in titles rgh-linkify-features and linkify-code in titles
rgh-linkify-features and linkify-code in titles rgh-linkify-features and linkify-code in titles
|
I checked the listener that has been modified in #4089 and it appears to work correctly (i.e. it's run the right number of times) Also I found which part still uses |
Now I see it, is it an issue? Also we need to anyways wait for GitHub to format it since we need it to in |
|
No, it can be merged as is. This is an issue on GitHub's part. We don't deal with titles anymore. Actually it's best to drop that selector from |
Only |
rgh-linkify-features and linkify-code in titles rgh-linkify-features and linkify-code in titles
rgh-linkify-features and linkify-code in titles rgh-linkify-features and linkify-code in titles
|
Are you sure? That selector only matches the conversation title in lists, but conversation titles appear in all sorts of places with different selectors, like the newsfeed, right? We surely have more than one selector |
We sure do. I thought you wanted me to drop only things related to the title. If i have time I will do it tomorrow |

Fixes #4129
Test URL's
This PR
Linkify issues:
mozilla/addons-linter#76