-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add confirm-short-comments feature
#4123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Ensure tests pass and that it’s mostly done and clean of unnecessary comments before converting to non-draft. Run |
(per fregante's review) - merged the two functions - fixed all errors
|
Sorry about not marking it as draft, it totally slipped my mind. |
- Added screenshot
confirm-too-short-comments featureconfirm-short-comments feature
- made the checks and questions separate for comment/new issue - renamed the feature - rephrased the questions text
Co-authored-by: yakov116 <16872793+yakov116@users.noreply.github.com>
- Now there's only one confirm() message for all cases - Added non-working workaround for form submission not working after the first blocking.
|
With my latest commit, there's now only
The only "fix" I found for the buttons becoming disabled is: but it doesn't seem to help. |
|
Try dispatching a fake InputEvent or using textFieldEdit.insert() The CI isn’t running on this branch. Once you got it working, send a new PR from a branch other than main and make sure to run |
|
Here is the new PR: #4141 Thanks a lot for your guidance and patience 🙂 |
I see that it still doesn't work as it should. If you can't finish the PR autonomously you're asking us to figure it out with you, which means that the PR isn't useful to us, sorry. |
|
I understand, and I am the one that should I ask sorry: I shouldn't make the PR in its current status, in the first place. I wish I could make it into an actually helpful contribution. |
Closes #3911
Test URLs
Any new/existing issue page: e.g.
https://github.com/sindresorhus/refined-github/issues/new
#3911
Screenshot