Skip to content

Restore base branch name in clean-conversation-headers #4103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fregante merged 1 commit into from
Mar 19, 2021
Merged

Restore base branch name in clean-conversation-headers #4103

fregante merged 1 commit into from
Mar 19, 2021

Conversation

@cheap-glitch
Copy link
Contributor

@cheap-glitch cheap-glitch commented Mar 15, 2021 •
edited
Loading

Closes #3808

Test URLs

Screenshots

Before After
Open PR (default branch)
Open PR (non-default branch)
Merged PR (same author)
Merged PR (different author)
Merged PR (different author, non-default branch)

@yakov116
Copy link
Member

yakov116 commented Mar 15, 2021

We're missing one test case: a PR merged by a different author into a non-default base branch. Anyone has a link?

#3150

fregante
fregante approved these changes Mar 17, 2021
View reviewed changes
Copy link
Member

@fregante fregante left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still hate this, it undoes 50% of the feature

Screen Shot 7

But it works I guess

@fregante fregante merged commit ddf0f09 into refined-github:main Mar 19, 2021
@cheap-glitch cheap-glitch deleted the restore-base-branch branch March 19, 2021 22:00
@fregante fregante mentioned this pull request Mar 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fregante fregante fregante approved these changes

Assignees

No one assigned

Labels

change request

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Base branch missing from PR view

3 participants

@cheap-glitch @yakov116 @fregante