Do I get your approval?

Tooltip is redundant, deployment should be lowercase (I don’t think there's anything in Title Case on GH), the icon makes it feel like an action, I'd rather have the regular external icon on the right side as suggested

Tooltip is redundant,

👍

deployment should be lowercase (I don’t think there's anything in Title Case on GH),

👍

the icon makes it feel like an action,

ok

I'd rather have the regular external icon on the right side* as suggested

GitHub style guide always has the icon on the left

The text is black or blue? I think black is ok

I'd rather have the regular external icon on the right side* as suggested

GitHub style guide always has the icon on the left

True

deployment should be lowercase (I don’t think there's anything in Title Case on GH),

👍

The comment above 👆 + every test link I opened showed 2 buttons in Chrome, at least the first time

I cannot understand why this is happening! I console.logged it and this observer runs 2 times yet on first-published-tag-for-merged-pr it does not 🤷

it runs 2 times yet on first-published-tag-for-merged-pr it does not 🤷

Probably it runs twice there too but then we have

https://github.com/sindresorhus/refined-github/blob/19330b2a4d1715c2d2496e6435a6b43263031c03/source/features/first-published-tag-for-merged-pr.tsx#L33

Maybe we should have an optimized on-conversation-header-update.ts? Written in a way that it can be used like this, maybe:

{
	additionalListeners: [
		onConversationHeaderUpdate
	],
	init
}

instead of

{
	init: () => onConversationHeaderUpdate(init)
}

I hope people don’t complain about wrapping in small viewports

We can hide it...

The position was a little too important in small windows

So I hid it for now

Thanks @yakov116 & @fregante! ❤️

Bug when the Edit button is visible. Can probably be fixed by a single space in the dom

Bug when the Edit button is visible. Can probably be fixed by a single space in the dom

Until the next header update.

I could not always get it to do that. Sometimes yes sometimes no. 🤷‍♂️