Repository navigation
Simplify hide-readme-header: Fixes "Jump to definition" bug - #4046
Merged
Merged
Conversation
fregante
marked this pull request as ready for review
March 2, 2021 10:55
fregante
changed the title
hide-readme-headerhide-readme-header: Fixes "Jump to definition" bug
1 task done
Contributor
|
this causes a spacing issue in GitHub Enterprise (2.21.14) due to the
|
Member
|
Noticed it today, I'll see if I can fix it tonight, otherwise PR welcome. |
Contributor
|
Well I think it stems from the fact @fregante removed code that is no longer needed in Github but still needed in older Github enterprise versions so I'm not sure what kind of PR would be accepted or if the solution is just to add custom css. |
Member
Author
|
Maybe the only change needed here would be to drop the background and border-bottom, which wouldn’t affect github.com |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4033
Test
https://github.com/sindresorhus/refined-github
https://github.com/probablykasper/vidl <-- the spacing should be reasonable, ref: #3495
https://github.com/no2chem/bigint-buffer <-- the popover position should be right, ref #4033
Screenshots