Repository navigation
Conversation
cheap-glitch
reviewed
Mar 2, 2021
| Add some test URLs | ||
| 1. Does this PR close/fix an existing issue? Write something like `Closes #10` | ||
| 2. What pages does this PR affect? Include some URLs where you tested the code or where reviewers can test it. | ||
| 3. Add a screenshot if your PR makes visual changes |
Contributor
There was a problem hiding this comment.
Maybe include a few guidelines to make better screenshots? e.g.:
- Clean up the area around the targeted element
- Zoom on the page for small UI changes
- Provide some context only if needed
- Use the "Before" and "After" arrows
I could use those remainders myself :)
Member
Author
There was a problem hiding this comment.
Yeah I was thinking about guidelines for screenshots in the readme but those either go in the readme (we have guidelines for the description in there) or in contributing
This screenshot is only meant to demonstrate the feature for review, not for the readme. In fact multiple screenshots or gifs are encouraged. See #4046 and #4029
Member
Author
|
OT: @yakov116 let's chill if we get repetitive/unwanted suggestions in my new meta issue (4049, no linking) 🙏 |
fregante
marked this pull request as ready for review
March 2, 2021 18:57
yakov116
approved these changes
Mar 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These explains better what we request and why. Also specify REAL URL because many unnecessarily post incomprehensible fake URLs for no good reason.