Skip to content

Add Firefox support #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sindresorhus merged 8 commits into from
May 24, 2017
Merged

Add Firefox support #403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c2676f0
Fix OP labels on Firefox
jgierer12 May 5, 2017
df18551
Fix tab size on Firefox
jgierer12 May 5, 2017
5810552
Make the linter happy
jgierer12 May 5, 2017
012edab
Merge branch 'master' into bug/firefox
jgierer12 May 12, 2017
94bb198
Resolve merge conflicts
jgierer12 May 12, 2017
856b84c
Merge branch 'master' into bug/firefox
jgierer12 May 19, 2017
f70ea43
Add Firefox manual installation instructions
jgierer12 May 19, 2017
87f1318
Update readme.md
sindresorhus May 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions extension/content.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,7 @@ svg.octicon.octicon-star.dashboard-event-icon {
.gist table.lines,
.highlight pre, /* Readme code blocks */
.blob-code-inner /* PR inline diff */ {
-moz-tab-size: 4 !important;
tab-size: 4 !important;
}

Expand Down
8 changes: 4 additions & 4 deletions extension/content.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,10 +313,10 @@ function addDiffViewWithoutWhitespaceOption(type) {

function addOPLabels() {
const comments = $('div.js-comment').toArray();
const newComments = comments.filter(comment => !$(comment).hasClass('refined-github-op'));
const newComments = $(comments).filter(':not(.refined-github-op)').toArray();

if (newComments) {
const commentAuthor = comment => $(comment).find('.author').text();
if (newComments.length > 0) {
const commentAuthor = comment => $(comment).find('strong .author').text();
let op;

if (pageDetect.isPR()) {
Expand All @@ -333,7 +333,7 @@ function addOPLabels() {
opComments = opComments.slice(1);
}

if (opComments) {
if (opComments.length > 0) {
const type = pageDetect.isPR() ? 'pull request' : 'issue';
const tooltip = `${op === getUsername() ? 'You' : 'This user'} submitted this ${type}.`;
const label = `
Expand Down
10 changes: 10 additions & 0 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,18 @@ And [lots](extension/content.css) [more...](extension/content.js)

## Install

### Chrome

Install it from the [Chrome Web Store](https://chrome.google.com/webstore/detail/refined-github/hlepfoohegkhhmjieoechaddaejaokhf) or [manually](http://superuser.com/a/247654/6877).

### Firefox

1. Download [this repo as a zip file](https://github.com/sindresorhus/refined-github/archive/master.zip)
2. Extract its contents
3. Visit `about:debugging#addons` in Firefox
4. Click on **Load Temporary Add-on**
5. Select the file `extension/manifest.json`


## Contribute

Expand Down