-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add Firefox support #403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Firefox support #403
Conversation
|
@AdrianoCahete @bogas04 @jdreesen do you want to take a look at this? Let me know if you find anything else that doesn't work in Firefox |
|
I expect to test this weekend. |
|
@AdrianoCahete Have you had the chance to test this out? |
|
@jgierer12 Just notifying you of #414 (comment) |
Sorry, I'm in the last release week in work, i didn't have time yet. :( |
|
After using this add-on on Firefox for a while now, I think we're ready to merge & submit to AMO. Going by npmhub/npmhub#20, it can take quite a while until an add-on gets approved, so I added manual installation instructions to the readme. We'll also have to look into web-ext for automatic deployment. |
|
For reference, this is how we've done it for npmhub: npm i --save-dev chrome-webstore-upload-cli webext
Edit: notice the new |
|
Looks good. @jgierer12 Can you open an issue/PR about automatic update submission? |
Fixing the things that don't work on Firefox yet:
Fixes #71
Once these are fixed, we can look into publishing it into the Add-on Store