Skip to content

Conversation

@jgierer12
Copy link
Contributor

@jgierer12 jgierer12 commented May 5, 2017

Fixing the things that don't work on Firefox yet:

Fixes #71

Once these are fixed, we can look into publishing it into the Add-on Store

@bogas04 bogas04 mentioned this pull request May 5, 2017
@jgierer12
Copy link
Contributor Author

@AdrianoCahete @bogas04 @jdreesen do you want to take a look at this? Let me know if you find anything else that doesn't work in Firefox

@AdrianoCahete
Copy link

I expect to test this weekend.

@hkdobrev
Copy link
Contributor

hkdobrev commented May 9, 2017

@AdrianoCahete Have you had the chance to test this out?

@hkdobrev
Copy link
Contributor

hkdobrev commented May 9, 2017

@jgierer12 Just notifying you of #414 (comment)

@AdrianoCahete
Copy link

Have you had the chance to test this out?

Sorry, I'm in the last release week in work, i didn't have time yet. :(

@jgierer12
Copy link
Contributor Author

jgierer12 commented May 14, 2017

@jgierer12
Copy link
Contributor Author

jgierer12 commented May 19, 2017

After using this add-on on Firefox for a while now, I think we're ready to merge & submit to AMO. Going by npmhub/npmhub#20, it can take quite a while until an add-on gets approved, so I added manual installation instructions to the readme. We'll also have to look into web-ext for automatic deployment.

cc @sindresorhus

@fregante
Copy link
Member

fregante commented May 20, 2017

For reference, this is how we've done it for npmhub:

npm i --save-dev chrome-webstore-upload-cli webext
  • .travis.yml

    env:
      - EXTENSION_ID=kbbbjimdjbjclaebffknlabpogocablj
    deploy:
      provider: script
      skip_cleanup: true
      script: npm run update-version; npm run release-cws; npm run release-amo
      on:
          branch: master
  • package.json

    {
        "scripts": {
          "release-amo": "cd extension && webext submit",
          "release-cws": "cd extension && webstore upload --auto-publish",
          "update-version": "dot-json extension/manifest.json version $(date -u +%Y.%-m.%-d.%-H%M)"
        }
    }

Edit: notice the new webext submit: mozilla/web-ext#804 (comment)

@sindresorhus sindresorhus merged commit 70082fd into refined-github:master May 24, 2017
@sindresorhus
Copy link
Member

Looks good.

@jgierer12 Can you open an issue/PR about automatic update submission?

@jgierer12 jgierer12 mentioned this pull request May 24, 2017
3 tasks
@jgierer12 jgierer12 deleted the bug/firefox branch June 15, 2017 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Firefox port

5 participants