@fregante what do we do about GHE?

@fregante what do we do about GHE?

You can see if someone with the new layout can test, otherwise these appear to be "clutter" cleanup features and they won't work. I am personally not as concerned with those breaking and focus more on the new features we add.

Ah yes, forgot about GHE. As I said in my PR most of those we can leave as is without breaking anything (for now), and for the two features that are actually affected I guess we can do something like

select('.muted-link, .Link--muted');

Thankfully it’s as easy as using both classes. Only the clean repo sidebar selector is going to be a little longer.

It still makes sense to use both classes in our markup, don’t undo that part

if only we could use :has() 😞

Another class seems to have changed: .text-gray became .color-secondary-text in some places (but not everywhere).

I've already fixed pr-approvals-count and align-issue-labels that depended on it (messed up my commit message, it should say "text-gray" instead of "link-gray"), but there are other features that may be affected and that I'm not very familiar with.

Are you saying this PR fixes #4026?

Are you saying this PR fixes #4026?

Yep

if only we could use :has() 😞

Hey, we can! 🎉 https://developer.mozilla.org/en-US/docs/Web/CSS/:is

We just need to update the minimum versions in the manifest

Possibly unrelated to this PR, but might also need class changes:

Are you also seeing these issues? (align-issue-labels is disabled)

• "Approved" isn't colored
• We have a feature that adds duplicate checkboxes

Are you also seeing these issues?

• "Approved" isn't colored
• We have a feature that adds duplicate checkboxes

First one (pr-approvals-count) is already fixed. I'm not seeing the other.

@fregante I'm seeing .link-gray in easier-pr-sha-copy.css but I can't figure out what it's supposed to target. Is this feature still relevant? Not seeing any SHAs on the PRs list page.

It’s worth checking out its blame to understand it

Let me know when you think you're done on this PR, I'd like to merge this soon (ideally together with the batch-open-conversations fix)

🙌

Merging for the time being because I keep seeing bugs and I don't if this already fixed them.

There are definitely more instances of text-gray and others, an additional global search/replace should fix more issues, including the duplicate checkboxes.

There are definitely more instances of text-gray and others

I'm aware, but I didn't want to blindly search & replace every instance seeing as there's still some .text-gray classes in the DOM (e.g. pinned issues), and that this affects features I'm not familiar with.

No worries, thanks for the detailed PR, it will be useful when blaming these changes 🙌