Improve reliability of `clean-repo-filelist-actions` #3995

cheap-glitch · 2021-02-18T13:52:15Z

LINKED ISSUES:

Fixes cleanup-repo-filelist-actions: Cannot read property 'classList' of null #3685
Fixes cleanup-repo-filelist-actions: Cannot read property 'replaceWith' of null #3963
TEST URLS:

SCREENSHOT:

Before
After

Continuation of #3531.
@orrc could you test this on GHE to see if it fixes #3963?

orrc · 2021-02-18T22:59:46Z

Yup, with this PR, the console error is gone on GHE, and the UI looks like the expected screenshot.

fregante · 2021-02-19T00:42:02Z

Does this PR intend to fix all open errors for this feature? I think there's more than one mentioned.

Also are the previous reviews already followed? I don't see any changes here except meta updates

cheap-glitch · 2021-02-19T07:46:14Z

Does this PR intend to fix all open errors for this feature?

Yes

Also are the previous reviews already followed?

Not all of them, it's a WIP

cheap-glitch · 2021-02-21T11:01:30Z

Setting the tooltip classes on the <details> or <summary> elements breaks some of the dropdown functionality (e.g. clicking outside to close stops working). I managed to solve this by wrapping the dropdowns in a <div class="tooltipped">. It works fine (tested on Firefox & Chromium), the only snag is that the tooltip appears when the dropdown is opened and stays visible until it's closed.

source/features/clean-repo-filelist-actions.tsx

yakov116

Needs a migration

source/options-storage.ts

Co-authored-by: yakov116 <16872793+yakov116@users.noreply.github.com>

`observe` won't throw in this case

fregante · 2021-02-22T18:26:01Z

I committed the rename separately so that the file can be followed as a "rename" on GitHub’s history

fregante · 2021-02-22T18:28:07Z

readme.md

 - [](# "clone-branch") [Clone a branch from the branches list.](https://user-images.githubusercontent.com/16872793/76802029-2a020500-67ad-11ea-95dc-bee1b1352976.png)
 - [](# "fork-source-link-same-view") [Points the “Forked from user/repository” link to current folder or file in the upstream repository.](https://user-images.githubusercontent.com/1402241/84795784-3722d000-aff8-11ea-9b34-97c01acf4fd4.png)
- [](# "clean-repo-filelist-actions") [Replaces the labels of some simple buttons on repository file lists with icons, making them take less space.](https://user-images.githubusercontent.com/44045911/88551471-7a3f7c80-d055-11ea-82f1-c558b7871824.png)
+- [](# "clean-repo-filelist-actions") [Replaces the labels of some simple buttons on repository filelists with icons, making them take less space.](https://user-images.githubusercontent.com/46634000/108366828-15b65b80-71f9-11eb-880a-5d6b0f0158b4.png)


Honestly I preferred the previous cropping and style. We usually copy those arrows between screenshots. The original arrows are in

To take a similar screenshot you'll likely have to disable latest-tag-button and maybe more

Is this better?

(not at real size)

fregante · 2021-02-22T18:52:00Z

selector-observer is relatively heavy so I prefer using it as little as possible.

In this case the "Go to file" button appears everywhere so I'm using it as an anchor for the other 2 buttons, which might not exist.

I tested the 4 links and this seems to work

…ch/refined-github into cleanup-repo-filelist-actions

This reverts commit fb589b5. This isn't just a comment, it describes the feature in a JSDoc comment.

fregante · 2021-02-24T06:00:45Z

More context

fregante · 2021-02-24T06:04:54Z

Love unmerged PRs reappearing!

kidonng and others added 15 commits October 15, 2020 09:49

Reimplement

5305582

Merge branch 'master' into cleanup-repo-filelist-actions

a8bb89a

Brackets

cb4c5fd

Merge branch 'master' into cleanup-repo-filelist-actions

083ee43

Rename

5437e4b

Match download folder button's style

2902cca

nasty

c1be24d

Comments

e082eef

Update screenshots

0a4ef6d

Feature rename

dc52cfb

Merge main into feature branch

c4066e3

Fix icons imports

783616b

Fix feature declaration

96c2577

Remove old feature

0e21d08

Fix readme & update screenshot

f6247d8

yakov116 added the enhancement label Feb 19, 2021

Fix tooltips

4c7cc9b

cheap-glitch marked this pull request as ready for review February 21, 2021 11:05

fregante reviewed Feb 21, 2021

View reviewed changes

source/features/clean-repo-filelist-actions.tsx Outdated Show resolved Hide resolved

source/features/clean-repo-filelist-actions.tsx Outdated Show resolved Hide resolved

source/features/clean-repo-filelist-actions.tsx Outdated Show resolved Hide resolved

cheap-glitch added 3 commits February 22, 2021 10:06

Use closest instead of chaining parents

53e9cae

Lint

ef1840e

Add explanatory comments

b698e08

yakov116 requested changes Feb 22, 2021

View reviewed changes

Add migration

15dfba4

yakov116 reviewed Feb 22, 2021

View reviewed changes

source/options-storage.ts Show resolved Hide resolved

Update source/options-storage.ts

66e27a5

Co-authored-by: yakov116 <16872793+yakov116@users.noreply.github.com>

fregante added 2 commits February 22, 2021 12:16

Drop unnecessary check

f39fd95

`observe` won't throw in this case

Temporarily undo rename to improve git history

c04bc1b

fregante self-assigned this Feb 22, 2021

Merge remote-tracking branch 'origin/main' into pr/3995

21136e0

Fix bad merge

30f28b0

fregante reviewed Feb 22, 2021

View reviewed changes

fregante changed the title ~~Improve reliability of cleanup-repo-filelist-actions~~ Improve reliability of clean-repo-filelist-actions Feb 22, 2021

fregante marked this pull request as draft February 22, 2021 18:33

Use single observer and add comments

b208fb2

fregante marked this pull request as ready for review February 22, 2021 18:50

fregante added 2 commits February 22, 2021 13:18

Remove unnecessary class

c560937

Move tooltipper to function

1b56d18

fregante removed their assignment Feb 22, 2021

fregante and others added 5 commits February 22, 2021 13:28

Lint

595358d

Better demo screenshot

c59a65c

Merge branch 'cleanup-repo-filelist-actions' of github.com:cheap-glit…

fa56c24

…ch/refined-github into cleanup-repo-filelist-actions

Fix comment

fb589b5

Revert "Fix comment"

7502af0

This reverts commit fb589b5. This isn't just a comment, it describes the feature in a JSDoc comment.

Screenshot with more context and better explain why the feature exists

f7d167a

fregante merged commit 0887b19 into refined-github:main Feb 24, 2021

cheap-glitch deleted the cleanup-repo-filelist-actions branch February 24, 2021 07:01

Uh oh!

Improve reliability of clean-repo-filelist-actions #3995

Improve reliability of clean-repo-filelist-actions #3995

Uh oh!

Conversation

cheap-glitch commented Feb 18, 2021 • edited by fregante Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

orrc commented Feb 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fregante commented Feb 19, 2021

Uh oh!

cheap-glitch commented Feb 19, 2021

Uh oh!

cheap-glitch commented Feb 21, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yakov116 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fregante commented Feb 22, 2021

Uh oh!

fregante Feb 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cheap-glitch Feb 23, 2021

Choose a reason for hiding this comment

Uh oh!

fregante commented Feb 22, 2021

Uh oh!

fregante commented Feb 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fregante commented Feb 24, 2021

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants

Improve reliability of `clean-repo-filelist-actions` #3995

Improve reliability of `clean-repo-filelist-actions` #3995

cheap-glitch commented Feb 18, 2021 •

edited by fregante

Loading

orrc commented Feb 18, 2021 •

edited

Loading

fregante Feb 22, 2021 •

edited

Loading

fregante commented Feb 24, 2021 •

edited

Loading