Hide and auto-expand Similar comments in hide-useless-comments
#3992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: paulocarneiro99 <paulo_carneiro@usp.br>
Member
|
Yes the logic in your post is correct |
fregante
requested changes
Feb 19, 2021
Member
fregante
left a comment
fregante
left a comment
There was a problem hiding this comment.
Both new selectors are rather generic and need to be improved
fregante
changed the title
hide-useless-commentshide-useless-comments
Member
|
Ouch, I think we got a problem:
See the error in #3647 |
fregante
reviewed
Feb 23, 2021
| } | ||
|
|
||
| // Expand all "similar comments" boxes | ||
| for (const similarCommentsExpandButton of select.all('.js-discussion .Details-content--closed > span:only-child')) { |
Member
There was a problem hiding this comment.
Maybe
Suggested change
| for (const similarCommentsExpandButton of select.all('.js-discussion .Details-content--closed > span:only-child')) { | |
| for (const similarCommentsExpandButton of select.all('.pagination-loader-container .Details-content--closed > span:only-child')) { |
Member
There was a problem hiding this comment.
We should fix this soon and I'll release an early version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LINKED ISSUES: Closes Expand but hide "1 similar comment" in
hide-useless-comments#3830TEST URLS: LICEcap 1.3.0 does not compatible with macOS Big Sur. justinfrankel/licecap#97
Picked up where #3839 left off. This PR:
This is not exactly what was described in #3830, rather it's following this review comment: #3839 (comment)
The idea is to consider every similar comment as useless by default, and not expand them to actually check their contents, since there can be a lot of them (I remember seeing issues with 200+ similar comments). Thoughts?