-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Avoid master noise in clean-conversation-headers
#3988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
My gut feeling is that we should only do this for a merged PR. I can see people having dev as the default branch and master as the release branch. |
Yeah, the current code and the other feature both already have this logic, right? There's a comment right here: aa6659a#diff-4998f02d19d02dcd71efd49bd1f943c4ac7256a392214cd0f3b7fced5d465b81R52 It should probably be brought over to this feature as well |
|
That made me realize. Exactly like for the previous feature, it's not just merged PRs, but also closed PRs. Example closed PR with |
|
I think it looks good. It might be worth adding the 2 to url-detection, but export const isMergedPR = (): boolean => exists('#partial-discussion-header [title="Status: Merged"]');
export const isClosedPR = (): boolean => exists('#partial-discussion-header [title="Status: Closed"], #partial-discussion-header [title="Status: Merged"]'); |
LINKED ISSUES:
Closes
clean-conversation-headersshould also considermasteras a default #3987TEST URLS:
fix for bundle-loader when using ESM parcel-bundler/parcel#78
Fix console errors #3844
SCREENSHOT:
None
Threw in a drop of lint hope its ok