Enable parse-backticks on Discussions
#3977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yakov116
reviewed
Feb 14, 2021
Co-authored-by: yakov116 <16872793+yakov116@users.noreply.github.com>
yakov116
changed the title
parse-backticks work in Discussionsparse-backticks on Discussions
Contributor
Author
|
Thanks for the review and the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing! 🍄
LINKED ISSUES: Closes
parse-backticksdoesn't work in Discussions #3975TEST URLS:
How to declare the types definitions `.types.d.ts` in VSCode/Sublime Text tophf/mpiv#50
https://github.com/tophf/mpiv/discussions
SCREENSHOT:
This PR adds 2 selectors in
source/features/parse-backticks.tsx(for discussion pages and listings) .