Skip to content

Conversation

@busches
Copy link
Member

@busches busches commented May 1, 2017

Fixes #389

This adds a new search filter on issues/PR pages with the text of
'Everything commented by you' with the filter of 'is:open
commenter:'

@sindresorhus
Copy link
Member

Looks pretty good.

You need to make sure it doesn't already exist. Sometimes it can cause duplicates because of caching. To reproduce, go to https://github.com/avajs/ava/issues, choose "Everything commented by you", click on any of the issues, click the back button in the browser, the filter list will now have a duplicate "Everything commented by you". See how this was solved in #376 (comment)

@busches busches force-pushed the add-your-comments-filter branch from 29cf79b to 2240448 Compare May 2, 2017 02:11
@busches
Copy link
Member Author

busches commented May 2, 2017

Thanks, I didn't check that condition. I've fixed the issue, please let me know what you think. I can also add it to the initial README if you like.

@busches busches force-pushed the add-your-comments-filter branch 2 times, most recently from a253241 to 0f77697 Compare May 2, 2017 02:17
@sindresorhus
Copy link
Member

I can also add it to the initial README if you like.

👍 With a screenshot

busches added 2 commits May 2, 2017 21:39
Fixes refined-github#389

This adds a new search filter on issues/PR pages with the text of
'Everything commented by you' with the filter of 'is:open
commenter:<username>'
@busches busches force-pushed the add-your-comments-filter branch from 0f77697 to c581a24 Compare May 3, 2017 02:51
@busches
Copy link
Member Author

busches commented May 3, 2017

README updated with the screenshot from the issue, as it worked quite well.

Copy link
Contributor

@paulmolluzzo paulmolluzzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@paulmolluzzo paulmolluzzo merged commit 3f14b3f into refined-github:master May 4, 2017
@paulmolluzzo
Copy link
Contributor

Thanks @busches! This is great! 👏 👏 👏

@busches busches deleted the add-your-comments-filter branch May 4, 2017 15:23
@leocaseiro
Copy link
Contributor

Thanks guys for the nice work 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants