-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add search filter for "Everything commented by you" #393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add search filter for "Everything commented by you" #393
Conversation
|
Looks pretty good. You need to make sure it doesn't already exist. Sometimes it can cause duplicates because of caching. To reproduce, go to https://github.com/avajs/ava/issues, choose "Everything commented by you", click on any of the issues, click the back button in the browser, the filter list will now have a duplicate "Everything commented by you". See how this was solved in #376 (comment) |
29cf79b to
2240448
Compare
|
Thanks, I didn't check that condition. I've fixed the issue, please let me know what you think. I can also add it to the initial README if you like. |
a253241 to
0f77697
Compare
👍 With a screenshot |
Fixes refined-github#389 This adds a new search filter on issues/PR pages with the text of 'Everything commented by you' with the filter of 'is:open commenter:<username>'
0f77697 to
c581a24
Compare
|
README updated with the screenshot from the issue, as it worked quite well. |
paulmolluzzo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
|
Thanks @busches! This is great! 👏 👏 👏 |
|
Thanks guys for the nice work 😄 |
Fixes #389
This adds a new search filter on issues/PR pages with the text of
'Everything commented by you' with the filter of 'is:open
commenter:'