Improve automatic dark mode support #3903
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for `prefers-color-scheme: dark` @media query and `[data-color-mode: auto]` reference : refined-github#3806 (comment)
shinenelson
force-pushed
the
fix/dark-mode
branch
from
de9613d to
ae1b421
Compare
fregante
requested changes
Jan 18, 2021
Member
fregante
left a comment
fregante
left a comment
There was a problem hiding this comment.
Rather than duplicating the selector and color we should prefer existing variables
fregante
reviewed
Jan 18, 2021
|
|
||
| [data-rgh-whitespace='space'] { | ||
| background-image: url('data:image/svg+xml,%3Csvg preserveAspectRatio="xMinYMid meet" viewBox="0 0 12 24" xmlns="http://www.w3.org/2000/svg"%3E%3Cpath d="M4.5 11C4.5 10.1716 5.17157 9.5 6 9.5C6.82843 9.5 7.5 10.1716 7.5 11C7.5 11.8284 6.82843 12.5 6 12.5C5.17157 12.5 4.5 11.8284 4.5 11Z" fill="rgba(36,41,46,25%)"/%3E%3C/svg%3E'); | ||
| background-image: url('data:image/svg+xml,%3Csvg preserveAspectRatio="xMinYMid meet" viewBox="0 0 12 24" xmlns="http://www.w3.org/2000/svg"%3E%3Cpath d="M4.5 11C4.5 10.1716 5.17157 9.5 6 9.5C6.82843 9.5 7.5 10.1716 7.5 11C7.5 11.8284 6.82843 12.5 6 12.5C5.17157 12.5 4.5 11.8284 4.5 11Z" fill="rgba(128, 128, 128, 50%)"/%3E%3C/svg%3E'); |
Member
There was a problem hiding this comment.
This is what @silverwind had initially suggested #3772, a color that sits right in the middle and works for both. I took these comparative screenshots but I don't remember which one is before and which is the after, but they're almost identical anyway
fregante
reviewed
Jan 18, 2021
fregante
changed the title
Member
This isn't resolved in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for
prefers-color-scheme: dark@media queryand
[data-color-mode: auto]LINKED ISSUES:
Further improvements to Dark mode #3806 (comment)
TEST ENVIRONMENT:
<html>tag hasdata-color-mode: autoSTEPS TO TEST
emoji or the reaction avatars