Skip to content

Conversation

@cheap-glitch
Copy link
Contributor

Thanks for contributing! 🍄

  1. LINKED ISSUES: Fixes clean-dashboard no longer hides the first line #3880

  2. TEST URLS: homepage feed

  3. SCREENSHOT:


Before After

Screenshot_2021-01-10 Build software better, together(1)

Screenshot_2021-01-10 Build software better, together(2)

I only have .watch-started events in my feed so I can only test those. Also, is there a reason why non-grouped fork events are left untouched?

@fregante
Copy link
Member

fregante commented Jan 10, 2021

Also, is there a reason why non-grouped fork events are left untouched?

Blame: #1824

Specifically look at how it's structured, grouped events don't have duplicate user/repo in the first place, they only say "User starred 2 repos"

@fregante fregante added the bug label Jan 10, 2021
@cheap-glitch
Copy link
Contributor Author

Specifically look at how it's structured, grouped events don't have duplicate user/repo in the first place, they only say "User starred 2 repos"

I'm talking about non-grouped fork events like this one:
Screenshot_2021-01-11 Build software better, together

We can apply to it a similar selector:

.rgh-clean-dashboard .dashboard .fork .color-border-secondary.flex-items-baseline .text-bold.text-gray-dark

Result:
Screenshot_2021-01-11 Build software better, together(1)

Should I add it to this PR or is there a reason it was left out?

@fregante fregante merged commit 6bcba9b into refined-github:master Jan 12, 2021
@fregante
Copy link
Member

@cheap-glitch cheap-glitch deleted the fix-clean-dashboard branch January 12, 2021 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

clean-dashboard no longer hides the first line

2 participants