Skip to content

Fix hide-comments-faster #3875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fregante merged 2 commits into from
Jan 9, 2021
Merged

Fix hide-comments-faster #3875

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1ca70d
Fix selector
cheap-glitch Jan 9, 2021
f7d7207
Fix overlapping dropdowns
cheap-glitch Jan 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions source/features/hide-comments-faster.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ function generateSubmenu(hideButton: Element): void {
const hideCommentForm = select('.js-comment-minimize', comment)!;

// Generate dropdown items
for (const reason of select.all('[name="classifier"] input:not([value=""])', comment)) {
for (const reason of select.all('[name="classifier"] option:not([value=""])', comment)) {
hideCommentForm.append(
<button
type="submit"
Expand All @@ -44,15 +44,15 @@ function generateSubmenu(hideButton: Element): void {

// Shows menu on top of mainDropdownContent when "Hide" is clicked;
// Hide it when dropdown closes.
// Uses `v-hidden` and `d-none` to avoid conflicts with `close-out-of-view-modals`
// Uses `v-hidden` to avoid conflicts with `close-out-of-view-modals`
function toggleSubMenu(hideButton: Element, show: boolean): void {
const dropdown = hideButton.closest('details')!;

// Native dropdown
select('details-menu', dropdown)!.classList.toggle('v-hidden', show);

// "Hide comment" dropdown
select('form.js-comment-minimize', dropdown)!.classList.toggle('d-none', !show);
select('form.js-comment-minimize', dropdown)!.classList.toggle('v-hidden', !show);
}

function resetDropdowns(event: delegate.Event): void {
Expand Down