Skip to content

Fix separate-draft-pr-button position #3873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fregante merged 3 commits into from
Jan 10, 2021
Merged

Fix separate-draft-pr-button position #3873

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c7e6799
Fix buttons positioning
cheap-glitch Jan 9, 2021
98e047a
Use better selector
cheap-glitch Jan 9, 2021
3d00df0
Fix code to account for new selector
cheap-glitch Jan 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions source/features/separate-draft-pr-button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,13 @@ function init(): void | false {
return false;
}

const buttonBar = select('.timeline-comment > :last-child', previewForm)!;
const createPrButtonGroup = select('.BtnGroup', buttonBar);
const createPrButtonGroup = select('.hx_create-pr-button');
if (!createPrButtonGroup) {
// Free accounts can't open Draft PRs in private repos, so this element is missing
return false;
}

const createPrDropdownItems = select.all('.select-menu-item', createPrButtonGroup);
const createPrDropdownItems = select.all('.select-menu-item', previewForm);

for (const dropdownItem of createPrDropdownItems) {
let title = select('.select-menu-item-heading', dropdownItem)!.textContent!.trim();
Expand All @@ -34,7 +33,7 @@ function init(): void | false {
classList.push('btn-primary');
}

buttonBar.prepend(
createPrButtonGroup.after(
<button
className={classList.join(' ')}
aria-label={description}
Expand All @@ -47,6 +46,7 @@ function init(): void | false {
);
}

select('details', createPrButtonGroup.parentElement!)!.remove();
createPrButtonGroup.remove();
}

Expand Down