Repository navigation
Conversation
might fix lint problems
shoter
changed the title
|
I’m hesitant to accept large UIs, but this appears relatively compact for what it does and it could be a solution to #615 (but not by default). Do you have time for the lengthy reviews that I expect on this bad boy? 😃 Some code can be dropped because we already have handlers/patterns for GitHub UI changes, some can be improved, and I think this could work better if implemented to look exactly like the label selector (a dropdown instead of a modal)
|
bx6tPIr1eBw
https://github.com/github/details-menu-element No need to manually hide the anything
|
I shortened the labels a bit, all that text was hard to parse and understand.
|
fregante
left a comment
fregante
left a comment
There was a problem hiding this comment.
I'm adding a new comment to test part of the feature
|
@shoter as you can see above, the "special case" is actually well-marked by GitHub. In this case, I added a review with comment to a resolved conversation. Please update the code accordingly (i.e. drop the "special case" and just detect it as a regular resolved/unresolved review comment) |
|
There are a few more improvements to be made:
|
fregante
changed the title
conversation-timeline-filter feature
| } | ||
|
|
||
| // We need to hide whole thread group if we have hidden all comments inside. | ||
| hasVisibleElement = hasVisibleElement || !threadContainer.hidden; |
There was a problem hiding this comment.
I think checking whether a whole review is resolved is easier than keeping track this way.
Before this loop you can probably just check “select.exists(unresolved review threads, item)”, and if not, just hide the whole item and return; No need to loop at that point.
|
I'll rewrite the missing parts in a new PR. No worries, the idea is good, but it required/s a lot of work. |
|
@fregante Thanks for that. Lately I could not find some time to have more look into it. I hope it makes it into repo :). |
|
Looks extremely useful, how do I enable this, 3 months in? EDIT: Nevermind, for some reason I thought this was a PR against GitHub and not a PR for browser plugin. Installed, works wonders, thanks for this @shoter! |
LINKED ISSUES:
Closes Toggle/Hide TimelineItem elements (e.g. added label etc) #3764
TEST URLS:
Use stages pipeline dotnet/aspnetcore#13040 - Contains all cases that I already found on github
Multipart pipe reader dotnet/aspnetcore#28939 ( Multipart pipe reader dotnet/aspnetcore#28939 (comment) shows comment attached to review that is unresolvable as it is attached to comment from previous review)
SCREENSHOT:
(I already fixed top-bar display issue above unresolved comments)
Description
Creates new functionality that let user filter not needed things on pull request timeline.
Can filter following things:
Additionally to quickly see all things in given timeline it has option to auto load hidden items - by default off.
I tested it on Github and Github Enterprise.
It is my first time contributing to this repo so if there is code duplication or I do not adhere to some standard then please correct me to do things right :).