Skip to content

Reposition tag-changelog-link#3841

Merged
fregante merged 11 commits intorefined-github:masterfrom
cheap-glitch:reposition-tag-changelog-link
Jan 8, 2021
Merged

Reposition tag-changelog-link#3841
fregante merged 11 commits intorefined-github:masterfrom
cheap-glitch:reposition-tag-changelog-link

Conversation

@cheap-glitch
Copy link
Contributor

@cheap-glitch cheap-glitch commented Dec 24, 2020

Thanks for contributing! 🍄

  1. LINKED ISSUES: Fixes Reposition tag-changelog-link #2699

  2. TEST URLS:

  1. SCREENSHOT:
Before After

This PR:

  • Moves the "Changelog" link above the GH dropdown. It relies on some GH class names so it might not be the best approach, but it keeps things simple.
  • Mitigates the content jump by reserving some space with CSS (there is still a jump but it happens much sooner in the page load). The magic number is not great though.
  • cleans up some outdated code regarding the "Verified" label (it's now properly wrapped inside a <li> element)

fregante
fregante reviewed Dec 24, 2020
View reviewed changes
@nedrebo nedrebo mentioned this pull request Dec 30, 2020
Closed
@cheap-glitch cheap-glitch marked this pull request as ready for review December 31, 2020 19:28
@cheap-glitch cheap-glitch requested a review from fregante January 3, 2021 12:05
fregante
fregante reviewed Jan 4, 2021
View reviewed changes
fregante
fregante reviewed Jan 4, 2021
View reviewed changes
@fregante
Copy link
Member

fregante commented Jan 5, 2021

The feature needs awaitDomReady: false or else the body class it added too late. This might need elementReady somewhere as well.

@fregante
Copy link
Member

fregante commented Jan 5, 2021 •
edited
Loading

Screen Shot

The link appears centered in when the window is <700px wide. (seen in chrome)

https://github.com/sindresorhus/refined-github/releases

@fregante fregante merged commit 46337dc into refined-github:master Jan 8, 2021
@fregante
Copy link
Member

fregante commented Jan 8, 2021

Thank you! That issue was about to turn 366 days old 💣

@cheap-glitch cheap-glitch deleted the reposition-tag-changelog-link branch January 8, 2021 11:20
@fregante
Copy link
Member

fregante commented Jan 10, 2021

It's probably not caused by this change, but the feature seems broken. I also just cleared the cache in the options as well.

https://github.com/sindresorhus/refined-github/releases

 Refined GitHub → tag-changelog-link → (2)
TypeError: null is not an object (evaluating '/\/releases\/tag\/(.*)/.exec(tagUrl)[1]')
parseTags — refined-github.js:5843:127
map
(anonymous function) — refined-github.js:5923:138
asyncFunctionResume
[native code]
promiseReactionJobWithoutPromise

Screen Shot 2

@yakov116
Copy link
Member

yakov116 commented Jan 10, 2021

I am not seeing the error

@cheap-glitch
Copy link
Contributor Author

cheap-glitch commented Jan 10, 2021

I just updated the extension and it's working fine for me too (tested on Firefox and Chromium).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fregante fregante fregante left review comments

@yakov116 yakov116 yakov116 left review comments

Assignees

No one assigned

Labels

enhancement

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reposition tag-changelog-link

3 participants

@cheap-glitch @fregante @yakov116