Expand but hide "1 similar comment" in hide-useless-comments #3830
#3839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
fregante
reviewed
Dec 23, 2020
| commentsToHide.push(comment); // Add all similar comments to be hidden | ||
| } | ||
|
|
||
| similarCommentBtn.click(); // Expand all the similar comments on this box |
Member
There was a problem hiding this comment.
This should be done only when the user expands the comments
| const similarCommentBoxes = select.all('.Details-element'); | ||
|
|
||
| for (const similarCommentsBox of similarCommentBoxes) { | ||
| const similarCommentBtn: HTMLElement = similarCommentsBox.querySelectorAll('.Details-content--closed')[0] as HTMLElement; |
Contributor
There was a problem hiding this comment.
select() can take a root element for the query as the second argument:
Suggested change
| const similarCommentBtn: HTMLElement = similarCommentsBox.querySelectorAll('.Details-content--closed')[0] as HTMLElement; | |
| const similarCommentBtn = select('.Details-content--closed', similarCommentsBox); |
Same for the next line.
Member
There was a problem hiding this comment.
There are several querySelectors while there should only be one at the top (and only one loop). Once my other comment is applied, this should become clearer
Member
|
#3827 was merged, this can now continue |
Member
|
Closing this for now, but please continue if you have time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LINKED ISSUES:
Closes Expand but hide "1 similar comment" in
hide-useless-comments#3830TEST URLS:
LICEcap 1.3.0 does not compatible with macOS Big Sur. justinfrankel/licecap#97 (comment)