Conversation
|
Hold off on the review I want to make changes |
source/options.tsx
Outdated
| setTimeout(() => { | ||
| void validateToken(); | ||
| }, 100); |
There was a problem hiding this comment.
| setTimeout(() => { | |
| void validateToken(); | |
| }, 100); | |
| setTimeout(validateToken, 100); |
But better yet if you dispatch an event at the end of https://github.com/fregante/webext-options-sync-per-domain/blob/dcc61fe58ab67d0982b2948cf3c1264375ef4096/index.ts#L129
Example: https://github.com/fregante/webext-options-sync/blob/master/index.ts#L253
… and then listen to that event specifically, instead of changing this listener
There was a problem hiding this comment.
I tried to figure this out. But I could not get it to work by listening to the event.
Co-Authored-By: Fregante <opensource@bfred.it>
Co-authored-by: Federico <me@fregante.com>
Co-authored-by: Federico <me@fregante.com>
|
Should all be good now. (I was looking over the code and I was wondering where my updated code was. Turns out I forgot to push :hehe) |
fregante
changed the title
|
Full demo in Chrome (field size changed only in demo):
Dark Chrome:
Dark Firefox:
Dark Safari:
|
|
|
3 participants
LINKED ISSUES:
Closes Verify token in options #3752
TEST URLS:
The options Page
SCREENSHOT:
I also fixed the dropdown listener since it was broken