Skip to content

Add labels to comments by OP #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sindresorhus merged 12 commits into from
Apr 25, 2017
Merged

Add labels to comments by OP #376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
b26b31f
Add labels to comments by OP
jgierer12 Apr 17, 2017
b3fa0fc
Reduce margin between multiple comment labels
jgierer12 Apr 17, 2017
e573f46
Fix linter errors
jgierer12 Apr 17, 2017
1b81e0d
Merge branch 'refactoring/linter' into enhancement/op-labels
jgierer12 Apr 17, 2017
974f1b7
Increase specificity for comments selector
jgierer12 Apr 17, 2017
db98e58
Delete yarn.lock
jgierer12 Apr 17, 2017
8990ae3
Merge branch 'refactoring/linter' into enhancement/op-labels
jgierer12 Apr 17, 2017
c0ef5c1
Document #376
jgierer12 Apr 20, 2017
760ebdc
Don't add OP label on first comment
jgierer12 Apr 20, 2017
f9d4e65
Merge branch 'master' into enhancement/op-labels
jgierer12 Apr 21, 2017
1df36ad
Ensure to add OP label only once
jgierer12 Apr 21, 2017
19eb403
Change class name for processed comments
jgierer12 Apr 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions extension/content.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,3 +565,12 @@ td.blob-code.blob-code-deletion:before {
.gist-copy-btn {
margin: 0 10px 0 0;
}

/* multiple comment labels margin */
.timeline-comment .timeline-comment-label + .timeline-comment-label {
margin-right: -5px;
}

.review-comment .timeline-comment-label + .timeline-comment-label {
margin-left: 5px;
}
28 changes: 28 additions & 0 deletions extension/content.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,26 @@ function addDiffViewWithoutWhitespaceOption(type) {
}
}

function addOPLabels(type) {
const label = `
<span class="timeline-comment-label tooltipped tooltipped-multiline tooltipped-s" aria-label="This user submitted this ${type}.">
Original Poster
</span>
`;

const comments = $('div.js-comment').toArray();
const commentAuthor = comment => $(comment).find('.author').text();
const op = commentAuthor(comments[0]);

const newComments = comments.slice(1).filter(comment => !$(comment).hasClass('refined-github-op'));

const opComments = newComments.filter(comment => commentAuthor(comment) === op);
$(opComments).filter('.timeline-comment').find('.timeline-comment-actions').after(label);
$(opComments).filter('.review-comment').find('.comment-body').before(label);

$(newComments).addClass('refined-github-op');
}

function addMilestoneNavigation() {
$('.repository-content').before(`
<div class="subnav">
Expand Down Expand Up @@ -427,6 +447,14 @@ document.addEventListener('DOMContentLoaded', () => {
markUnread.setup();
}

if (pageDetect.isIssue()) {
addOPLabels('issue');
}

if (pageDetect.isPR()) {
addOPLabels('pull request');
}

if (pageDetect.isMilestone()) {
addMilestoneNavigation();
}
Expand Down
1 change: 1 addition & 0 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ Our hope is that GitHub will notice and implement some of these much needed impr
- [Adds links to patch and diff for each commit](https://cloud.githubusercontent.com/assets/737065/13605562/22faa79e-e516-11e5-80db-2da6aa7965ac.png)
- [Differentiates merge commits from regular commits](https://cloud.githubusercontent.com/assets/170270/14101222/2fe2c24a-f5bd-11e5-8b1f-4e589917d4c4.png)
- [Adds a `Copy` button to gist files](https://cloud.githubusercontent.com/assets/170270/21074840/5dc37578-bf03-11e6-9fd9-501d73edef87.png)
- [Adds labels to comments by the original poster](https://cloud.githubusercontent.com/assets/4331946/25075520/d62fbbd0-2316-11e7-921f-ab736dc3522e.png)
- [Adds navigation to milestone pages](https://cloud.githubusercontent.com/assets/170270/25217211/37b67aea-25d0-11e7-8482-bead2b04ee74.png)
- Easier copy-pasting from diffs by making +/- signs unselectable
- Shows the reactions popover on hover instead of click
Expand Down