Skip to content

Conversation

@jgierer12
Copy link
Contributor

@jgierer12 jgierer12 commented Apr 16, 2017

The same labels/milestones navigation buttons that are found on the milestone list page are now also on single milestone pages.

Before: Before

After: After

Fixes #366

This adds the same labels/milestones navigation buttons to single milestone
pages that's found on the milestone list
@paulmolluzzo
Copy link
Contributor

Thanks for the PR! This looks really good, but there's a failing build, most of which isn't actually from this PR.

I don't want to get off on a tangent, but the capitalized-comments errors could be fixed automatically with xo --fix.

The Unexpected chained assignment. no-multi-assign can be fixed or we can just ignore the line.

The warning on complexity we can leave.

Or someone can open a PR that fixes the issues.

@jgierer12
Copy link
Contributor Author

Thanks, I fixed the linter issues!

@paulmolluzzo
Copy link
Contributor

👍

@hkdobrev? You opened #366, what do you think?

@paulmolluzzo
Copy link
Contributor

Any comments on this PR or are we OK to 🚢 ?

@sindresorhus sindresorhus merged commit c55fd32 into refined-github:master Apr 20, 2017
@sindresorhus
Copy link
Member

Looks good :)

sindresorhus added a commit that referenced this pull request Apr 20, 2017
@hkdobrev
Copy link
Contributor

🙌 Thanks @jgierer12!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants