Skip to content

Fetch widget for view-markdown-source instead of maintaining a copy of it #3670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fregante merged 11 commits into from
Oct 21, 2020
Merged

Fetch widget for view-markdown-source instead of maintaining a copy of it #3670

fregante merged 11 commits into from
Oct 21, 2020

Conversation

@yakov116
Copy link
Member

@yakov116 yakov116 commented Oct 19, 2020

@yakov116 yakov116 requested a review from fregante October 19, 2020 13:14
fregante
fregante requested changes Oct 19, 2020
View reviewed changes
yakov116
yakov116 commented Oct 20, 2020
View reviewed changes
@yakov116 yakov116 requested a review from fregante October 20, 2020 03:38
fregante
fregante requested changes Oct 20, 2020
View reviewed changes
fregante
fregante reviewed Oct 20, 2020
View reviewed changes
yakov116 and others added 2 commits October 20, 2020 08:41
@yakov116 @fregante
Apply suggestions from code review
de43d47 
Co-authored-by: Federico <me@fregante.com>
@yakov116
Fix Build
debf2f1
@yakov116
Copy link
Member Author

yakov116 commented Oct 20, 2020

Working 🎉

Thanks for confirming my thoughts

Don't taint fetchDom with this, it's unlikely we ever need it again.

fregante
fregante reviewed Oct 20, 2020
View reviewed changes
fregante
fregante reviewed Oct 20, 2020
View reviewed changes
@yakov116 @fregante
Update source/features/view-markdown-source.tsx
7250ee2 
Co-authored-by: Federico <me@fregante.com>
@yakov116
Copy link
Member Author

yakov116 commented Oct 21, 2020

Is the title ok?

@fregante fregante changed the title Avoid recreating the line-actions in view-markdown-source Fetch widget for view-markdown-source instead of maintaining a copy of it Oct 21, 2020
@fregante fregante merged commit 42ce2df into master Oct 21, 2020
@fregante fregante deleted the fetch_the_dom branch October 21, 2020 01:12
@fregante fregante mentioned this pull request Jan 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fregante fregante fregante approved these changes

Assignees

No one assigned

Labels

enhancement

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yakov116 @fregante