Meta: remove no-longer-necessary alignment CSS #3660
Conversation
source/features/github-bugs.css
Outdated
|
|
||
| /* Align dropdown button on file page */ | ||
| #blob-more-options-details { | ||
| margin-top: 5.6px; |
There was a problem hiding this comment.
This is to align the dropdown button (whose height is 20.8px) with the find file button (whose height is 32px)
(32 - 20.8) / 2 = 5.6
There was a problem hiding this comment.
There's display: flex on that line, just add align-items: center !important; on .d-flex to align the whole line since it's not aligned:
There was a problem hiding this comment.
I hope this is fixed across the board, the whole bar is probably the most broken-looking part of GitHub/Refined GitHub. Example: #3671 (not totally RG’s fault, but every element has its own alignment)
source/features/github-bugs.css
Outdated
| border-bottom-right-radius: 5px; | ||
| } | ||
|
|
||
| /* Align author name on PR sticky header */ |
There was a problem hiding this comment.
This issue has been confirmed on the latest Chrome 86 (stable build)
There was a problem hiding this comment.
Give it time. I don’t want more CSS code to fix something they probably will fix soon
There was a problem hiding this comment.
This issue has been there for a while, so does the misaligned dropdown (though the former one used to be only noticeable in newer versions of Chrome).
But I agree these fixes should not be hurried. Do we have some kind of staging area/tracker for this kind of GitHub bugs (like an issue)?
There was a problem hiding this comment.
- It's just on your computer
- This CSS affects everyone, not just Chrome users, so if this fixes it for you, it breaks everyone else’s
There was a problem hiding this comment.
Is it possible that you have corrupted font files?
There was a problem hiding this comment.
- It's just on your computer
I just asked a fellow and he can also reproduce it. We are both on Windows, is that the problem?
I will test it on Linux later
There was a problem hiding this comment.
On Chrome 86 on Windows as well and it looks fine.
There was a problem hiding this comment.
Are you and your fellow on zh-CN locales? I don’t have experience with that, but I guess it could affect alignment.
Either way it sounds like a Chrome bug on those 2 computers since every other browser displays it correctly, on macOS too.
There was a problem hiding this comment.
Are you and your fellow on zh-CN locales?
You are right! The issue disappeared right after I changed my locale.
Then I have no problem with removing the fix. 👍 I will keep it in my custom style.
|
Hey @kidonng from the first set to screenshots you shared, looks like you have some RGH feature disabled.
and this for internal source branches:
I don't see the entire "fregante wants to merge 3 commits into |
|
It's from the sticky bar. |
It confused me too at first, that's why screenshots should include a little more context sometimes. |
fregante
changed the title
|
I’ll merge the part of this PR that is ready since the rest needs more work. |
6 participants
Uh oh!
There was an error while loading. Please reload this page.