Skip to content

Restore embed-gist-inline feature #3640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yakov116 merged 8 commits into from
Oct 16, 2020
Merged

Restore embed-gist-inline feature #3640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
18a7bc2
Restore `embed-gist-inline` feature
yakov116 Oct 12, 2020
2d7ad4d
Use Promise
yakov116 Oct 12, 2020
f5425cd
Use await
yakov116 Oct 13, 2020
d19c94d
Revert "Use await"
yakov116 Oct 13, 2020
0a04976
Update source/background.ts
yakov116 Oct 13, 2020
d09ed7b
Remove double promise
yakov116 Oct 13, 2020
8922259
Merge branch 'master' into embed-gist-inline
yakov116 Oct 14, 2020
c8acc4c
Make it a one-liner
yakov116 Oct 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions source/background.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,3 +42,9 @@ browser.runtime.onInstalled.addListener(async ({reason}) => {

// GitHub Enterprise support
addDomainPermissionToggle();

// `background` fetch required to avoid avoid CORB introduced in Chrome 73 https://chromestatus.com/feature/5629709824032768
// Don’t turn this into an `async` function https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/runtime/onMessage#addListener_syntax
browser.runtime.onMessage.addListener(({request}): Promise<Response> | void => {
return fetch(request).then(async response => response.json());
});
9 changes: 2 additions & 7 deletions source/features/embed-gist-inline.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import select from 'select-dom';
import * as pageDetect from 'github-url-detection';

import features from '.';
import {isFirefox} from '../github-helpers';

const isGist = (link: HTMLAnchorElement): boolean =>
!link.pathname.includes('.') && // Exclude links to embed files
Expand All @@ -20,8 +19,8 @@ async function embedGist(link: HTMLAnchorElement): Promise<void> {
link.after(info);

try {
const response = await fetch(`${link.href}.json`);
const gistData = await response.json();
// Get the gist via background.js due to CORB policies introduced in Chrome 73
const gistData = await browser.runtime.sendMessage({request: `${link.href}.json`});

const files = domify.one(gistData.div)!;
const fileCount = files.children.length;
Expand Down Expand Up @@ -60,9 +59,5 @@ void features.add({
include: [
pageDetect.hasComments
],
exclude: [
// https://github.com/sindresorhus/refined-github/issues/2022
() => isFirefox
],
init
});