Improve cleanup-repo-filelist-actions’s reliability
#3531
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| import React from 'dom-chef'; | ||
| import onetime from 'onetime'; | ||
| import {observe} from 'selector-observer'; | ||
| import PlusIcon from 'octicon/plus.svg'; | ||
| import SearchIcon from 'octicon/search.svg'; | ||
| import * as pageDetect from 'github-url-detection'; | ||
|
|
||
| import features from '.'; | ||
|
|
||
| function init(): void { | ||
| // Only select desktop version of the button | ||
| observe('.d-flex > [data-hotkey="t"]:not(.rgh-clean-actions)', { | ||
| add(searchButton) { | ||
| searchButton.classList.add('tooltipped', 'tooltipped-ne', 'rgh-clean-actions'); | ||
| searchButton.setAttribute('aria-label', 'Go to file'); | ||
|
|
||
| searchButton.firstChild!.replaceWith(<SearchIcon/>); | ||
|
|
||
| // Exclude logged out, mobile or file pages | ||
| const addButtonText = searchButton.nextElementSibling?.querySelector('.d-md-flex'); | ||
| if (addButtonText) { | ||
| addButtonText.parentElement!.classList.add('tooltipped', 'tooltipped-ne'); | ||
|
There was a problem hiding this comment. 👇 (if
Member
There was a problem hiding this comment. In what case it's not a summary? My understanding is that it's a summary when it's a dropdown, and it always is. |
||
| addButtonText.parentElement!.setAttribute('aria-label', 'Add file'); | ||
|
|
||
| addButtonText.classList.replace('d-md-flex', 'd-md-block'); | ||
| addButtonText.firstChild!.replaceWith(<PlusIcon/>); | ||
| } | ||
| } | ||
| }); | ||
|
|
||
| observe('get-repo summary:not(.rgh-clean-actions)', { | ||
| add(button) { | ||
| button.classList.add('tooltipped', 'tooltipped-ne', 'rgh-clean-actions'); | ||
|
There was a problem hiding this comment. Could you check if click outside to close works?. That's the reason I moved that classes from |
||
| button.setAttribute('aria-label', 'Clone, open or download'); | ||
|
|
||
| button.firstElementChild!.nextSibling!.remove(); | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| void features.add({ | ||
| id: __filebasename, | ||
| description: 'Replaces the labels of some simple buttons on repository filelists with icons, making them take less space.', | ||
| screenshot: 'https://user-images.githubusercontent.com/44045911/96283396-bbb94580-100e-11eb-9480-17954bb3a811.png' | ||
| }, { | ||
| include: [ | ||
| pageDetect.isRepoTree, | ||
| pageDetect.isSingleFile | ||
| ], | ||
| exclude: [ | ||
| pageDetect.isEmptyRepo | ||
| ], | ||
| init: onetime(init) | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some padding is ok, but this is excessive. Can you avoid it and instead use higher-resolution screenshots? Zoom the page at 200% if possible before taking a screenshot