-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Update dependencies and reduce cache duration #3496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can you fix #3302 while we're at it? |
|
I was not sure if they all should be or the ones that make sense to be changed? |
Co-authored-by: Federico <me@fregante.com>
| @@ -61,13 +61,13 @@ | |||
| "shorten-repo-url": "^2.0.0", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come mem wasn't updated? There's 6.1.0
I generally use to check what's available and update all sub-dependencies correctly. npm still can't be trusted with the lock
npx npm-check -u && rm -rf node_modules package-lock.json && npm install && npm run testThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You said you did not want to update it
I actually had left this on 6.0.1 because it's technically a better version since we don't use
mem.clearOriginally posted by @fregante in #3168 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, because I thought that 6.1.0 was the most recent feature, but the "worse version" still hasn't been published yet sindresorhus/memoize#58 (comment)
You can use 6.1.0 now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lock it @ 6.1.0?
| "ts-node": "^9.0.0", | ||
| "type-fest": "^0.16.0", | ||
| "typescript": "^4.1.0-dev.20200810", | ||
| "typescript": "^4.0.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're going back? I want to make sure that the reason why this was added has been solved in v4. Tonight I have no data left though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked I get no messages. I put it on the latest stable version. want me to check the latest dev version?
Tonight I have no data left though
You run on limited data?? - Wow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You run on limited data?? - Wow
WiFi wasn't working and promptly ran out of 4G data 🤣
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested as well, it works
fregante
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest of the times looks fine
source/features/highlight-collaborators-and-own-conversations.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Federico <me@fregante.com>
Fixes #3302
#3489 (comment)