Skip to content

Conversation

@yakov116
Copy link
Member

@yakov116 yakov116 commented Aug 24, 2020

@fregante
Copy link
Member

Can you fix #3302 while we're at it?

@fregante fregante changed the title Update Dependencies Update dependencies Aug 24, 2020
@fregante fregante added enhancement meta Related to Refined GitHub itself labels Aug 24, 2020
@yakov116
Copy link
Member Author

I was not sure if they all should be or the ones that make sense to be changed?

Co-authored-by: Federico <me@fregante.com>
@@ -61,13 +61,13 @@
"shorten-repo-url": "^2.0.0",
Copy link
Member

@fregante fregante Aug 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come mem wasn't updated? There's 6.1.0

I generally use to check what's available and update all sub-dependencies correctly. npm still can't be trusted with the lock

npx npm-check -u && rm -rf node_modules package-lock.json && npm install && npm run test

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You said you did not want to update it

I actually had left this on 6.0.1 because it's technically a better version since we don't use mem.clear

Originally posted by @fregante in #3168 (comment)

Copy link
Member

@fregante fregante Aug 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, because I thought that 6.1.0 was the most recent feature, but the "worse version" still hasn't been published yet sindresorhus/memoize#58 (comment)

You can use 6.1.0 now

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lock it @ 6.1.0?

"ts-node": "^9.0.0",
"type-fest": "^0.16.0",
"typescript": "^4.1.0-dev.20200810",
"typescript": "^4.0.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going back? I want to make sure that the reason why this was added has been solved in v4. Tonight I have no data left though

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked I get no messages. I put it on the latest stable version. want me to check the latest dev version?

Tonight I have no data left though

You run on limited data?? - Wow

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You run on limited data?? - Wow

WiFi wasn't working and promptly ran out of 4G data 🤣

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested as well, it works

Copy link
Member

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of the times looks fine

yakov116 and others added 2 commits August 25, 2020 16:47
@fregante fregante changed the title Update dependencies Update dependencies and reduce caches Aug 26, 2020
@fregante fregante changed the title Update dependencies and reduce caches Update dependencies and reduce cache duration Aug 26, 2020
@fregante fregante merged commit 88606fc into refined-github:master Aug 26, 2020
@yakov116 yakov116 deleted the dep branch August 26, 2020 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement meta Related to Refined GitHub itself

Development

Successfully merging this pull request may close these issues.

Reduce all caches to 1 hour or less

2 participants