Lint #3478
Merged
Lint #3478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dont this will work on domReady = false
The load is different if you switch to a single commit
yakov116
commented
Aug 18, 2020
yakov116
commented
Aug 18, 2020
Comment on lines
+72
to
+73
| init, | ||
| deinit: () => observer.abort(), |
Member
Author
There was a problem hiding this comment.
Needed since when you change from a commit page to the file changes tab, we need to reload the list.
yakov116
commented
Aug 18, 2020
yakov116
commented
Aug 18, 2020
fregante
reviewed
Aug 18, 2020
We don't need to justify every line
fregante
reviewed
Aug 18, 2020
Co-Authored-By: Fregante <opensource@bfred.it>
This reverts commit e4728b6.
yakov116
commented
Aug 18, 2020
fregante
approved these changes
Aug 19, 2020
Member
|
If you’re looking for more linting (separate PR maybe) there are a few rules here that were disabled, but are helpful and probably are not a problem to us: https://github.com/xojs/eslint-config-xo-typescript/blob/master/index.js Have a look, perhaps you can try adding them to our config and seeing if they’re reasonable. If they’re too difficult to add or seem to require a rewrite (or many eslint-ignore), let me know and don’t lose your mind over it 😃 |
Member
Author
|
I will git it a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this for word definition
repo-ageclone-branchfeatures.errorinstead of throwing (firefox)highlight-deleted-and-added-files-in-diffs. When switching pages, the list needs a reload.clean-conversation-headerserror see Addclean-conversation-headersfeature #3408 (comment) (not sure if this fixes both errors)