Minor style fixes for GitHub bugs #3444
Conversation
|
This should not be necessary, let’s wait and see if GitHub fixes it first |
|
Then let's just add margin to the sticky sidebar, which should better be a separate PR so it can be merged without being constrained by this one. |
|
Sounds good. Can you create a new |
source/github-bugs.css
Outdated
| /* Align author name on PR sticky header (https://github.com/sindresorhus/refined-github/pull/3444) */ | ||
| .sticky-content .author.css-truncate-target { | ||
| vertical-align: -4px; | ||
| } | ||
|
|
There was a problem hiding this comment.
| /* Align author name on PR sticky header (https://github.com/sindresorhus/refined-github/pull/3444) */ | |
| .sticky-content .author.css-truncate-target { | |
| vertical-align: -4px; | |
| } |
Before:
I'm not seeing this issue anywhere, with or without RG
Regular: 
Stickied: 
There was a problem hiding this comment.
This happens on my Edge and Chrome, but not on Firefox. @yakov116 do you have this problem?
There was a problem hiding this comment.
Maybe how Chromium handles vertical-align: top is different from Firefox. I added vertical-align: -4px to Firefox and the text's position doesn't change.
There was a problem hiding this comment.
You likely have some conflicting styles. I'm not seeing that in any browser and I don't expect it to last either way. It should be dropped from this PR
There was a problem hiding this comment.
You likely have some conflicting styles
How is that possible? I tested it in a newly installed Chrome
There was a problem hiding this comment.
I think I figured out: latest stable Chromium doesn't have this issue, but Chromium Dev does (which affects both Chrome and Edge)
I'm not sure it's something broken by Chromium (which will be fixed by them) or it will broke in the future (it's some rendering changes), but it's fine to remove it right now.
Update on 2020-08-24: Still broken on Chrome Dev 86.0.4238.2 😥 I guess when 86 hits stable (Oct 6) we will need to fix this
2 participants
Edit: fix removed
Test: #3442
Before:
After:
Test:
429a03a(#3442)Before:
After:
Test: 62c3539
Before:
After:
