refined-github · fregante · Aug 10, 2020 · Aug 8, 2020 · Aug 8, 2020 · Aug 8, 2020
diff --git a/contributing.md b/contributing.md
@@ -68,11 +68,8 @@ features.add({
 	/** Whether to wait for DOM ready before runnin `init`. `false` makes `init` run right as soon as `body` is found. @default true */
 	waitForDomReady: false,
 
-	/** Whether to re-run `init` on pages loaded via AJAX. @default true */
-	repeatOnAjax: false,
-
 	/** Rarely needed: When pressing the back button, the DOM and listeners are still there, so normally `init` isn’t called again. If this is true, it’s called anyway. @default false */
-	repeatOnAjaxEvenOnBackButton: true,
+	repeatOnBackButton: true,
 	include: [
 		pageDetect.isUserProfile,
 		pageDetect.isRepo

diff --git a/source/features/clean-rich-text-editor.tsx b/source/features/clean-rich-text-editor.tsx
@@ -1,5 +1,6 @@
 import './clean-rich-text-editor.css';
 import select from 'select-dom';
+import onetime from 'onetime';
 import * as pageDetect from 'github-url-detection';
 
 import features from '.';
@@ -28,6 +29,5 @@ void features.add({
 		pageDetect.isRepo
 	],
 	waitForDomReady: false,
-	repeatOnAjax: false,
-	init: hideButtons
+	init: onetime(hideButtons)
 });
diff --git a/source/features/close-out-of-view-modals.tsx b/source/features/close-out-of-view-modals.tsx
@@ -1,3 +1,4 @@
+import onetime from 'onetime';
 import delegate from 'delegate-it';
 
 import features from '.';
@@ -31,6 +32,5 @@ void features.add({
 	screenshot: 'https://user-images.githubusercontent.com/1402241/37022353-531c676e-2155-11e8-96cc-80d934bb22e0.gif'
 }, {
 	waitForDomReady: false,
-	repeatOnAjax: false,
-	init
+	init: onetime(init)
 });
diff --git a/source/features/comment-fields-keyboard-shortcuts.tsx b/source/features/comment-fields-keyboard-shortcuts.tsx
@@ -1,5 +1,6 @@
 import React from 'dom-chef';
 import select from 'select-dom';
+import onetime from 'onetime';
 import delegate from 'delegate-it';
 import * as pageDetect from 'github-url-detection';
 
@@ -75,6 +76,5 @@ void features.add({
 		pageDetect.hasRichTextEditor
 	],
 	waitForDomReady: false,
-	repeatOnAjax: false,
-	init
+	init: onetime(init)
 });
diff --git a/source/features/copy-on-y.tsx b/source/features/copy-on-y.tsx
@@ -29,7 +29,7 @@ void features.add({
 		pageDetect.isSingleFile
 	],
 	waitForDomReady: false,
-	repeatOnAjaxEvenOnBackButton: true,
+	repeatOnBackButton: true,
 	init,
 	deinit
 });
diff --git a/source/features/deprioritize-marketplace-link.tsx b/source/features/deprioritize-marketplace-link.tsx
@@ -1,5 +1,6 @@
 import React from 'dom-chef';
 import select from 'select-dom';
+import onetime from 'onetime';
 import domLoaded from 'dom-loaded';
 import elementReady from 'element-ready';
 import * as pageDetect from 'github-url-detection';
@@ -30,6 +31,5 @@ void features.add({
 		pageDetect.isGist
 	],
 	waitForDomReady: false,
-	repeatOnAjax: false,
-	init
+	init: onetime(init)
 });
diff --git a/source/features/embed-gist-via-iframe.tsx b/source/features/embed-gist-via-iframe.tsx
@@ -1,4 +1,5 @@
 import select from 'select-dom';
+import onetime from 'onetime';
 import * as pageDetect from 'github-url-detection';
 
 import features from '.';
@@ -32,6 +33,5 @@ void features.add({
 	include: [
 		pageDetect.isSingleGist
 	],
-	repeatOnAjax: false,
-	init
+	init: onetime(init)
 });
diff --git a/source/features/esc-to-deselect-line.tsx b/source/features/esc-to-deselect-line.tsx
@@ -1,3 +1,4 @@
+import onetime from 'onetime';
 import * as pageDetect from 'github-url-detection';
 
 import features from '.';
@@ -31,6 +32,5 @@ void features.add({
 		pageDetect.hasCode
 	],
 	waitForDomReady: false,
-	repeatOnAjax: false,
-	init
+	init: onetime(init)
 });
diff --git a/source/features/file-finder-buffer.tsx b/source/features/file-finder-buffer.tsx
@@ -57,6 +57,5 @@ void features.add({
 		pageDetect.isRepo
 	],
 	waitForDomReady: false,
-	repeatOnAjax: false,
-	init
+	init: onetime(init)
 });
diff --git a/source/features/hide-navigation-hover-highlight.tsx b/source/features/hide-navigation-hover-highlight.tsx
@@ -1,4 +1,6 @@
 import './hide-navigation-hover-highlight.css';
+import onetime from 'onetime';
+
 import features from '.';
 
 const className = 'rgh-no-navigation-highlight';
@@ -16,6 +18,5 @@ void features.add({
 	screenshot: false
 }, {
 	waitForDomReady: false,
-	repeatOnAjax: false,
-	init
+	init: onetime(init)
 });
diff --git a/source/features/hide-own-stars.tsx b/source/features/hide-own-stars.tsx
@@ -1,4 +1,5 @@
 import select from 'select-dom';
+import onetime from 'onetime';
 import * as pageDetect from 'github-url-detection';
 
 import features from '.';
@@ -21,6 +22,5 @@ void features.add({
 		pageDetect.isDashboard
 	],
 	onlyAdditionalListeners: true,
-	repeatOnAjax: false,
-	init
+	init: onetime(init)
 });
diff --git a/source/features/hide-useless-newsfeed-events.tsx b/source/features/hide-useless-newsfeed-events.tsx
@@ -1,4 +1,5 @@
 import './hide-useless-newsfeed-events.css';
+import onetime from 'onetime';
 import * as pageDetect from 'github-url-detection';
 
 import features from '.';
@@ -16,6 +17,5 @@ void features.add({
 		pageDetect.isDashboard
 	],
 	waitForDomReady: false,
-	repeatOnAjax: false,
-	init
+	init: onetime(init)
 });
diff --git a/source/features/hide-watch-and-fork-count.tsx b/source/features/hide-watch-and-fork-count.tsx
@@ -1,4 +1,5 @@
 import './hide-watch-and-fork-count.css';
+import onetime from 'onetime';
 import * as pageDetect from 'github-url-detection';
 
 import features from '.';
@@ -16,6 +17,5 @@ void features.add({
 		pageDetect.isRepo
 	],
 	waitForDomReady: false,
-	repeatOnAjax: false,
-	init
+	init: onetime(init)
 });
diff --git a/source/features/improve-shortcut-help.tsx b/source/features/improve-shortcut-help.tsx
@@ -1,5 +1,6 @@
 import React from 'dom-chef';
 import select from 'select-dom';
+import onetime from 'onetime';
 
 import features from '.';
 import {isEditable} from '../helpers/dom-utils';
@@ -66,6 +67,5 @@ void features.add({
 	screenshot: 'https://user-images.githubusercontent.com/29176678/36999174-9f07d33e-20bf-11e8-83e3-b3a9908a4b5f.png'
 }, {
 	waitForDomReady: false,
-	repeatOnAjax: false,
-	init
+	init: onetime(init)
 });
diff --git a/source/features/index.tsx b/source/features/index.tsx
@@ -30,11 +30,8 @@ interface FeatureLoader extends Partial<InternalRunConfig> {
 	/** Whether to wait for DOM ready before runnin `init`. `false` makes `init` run right as soon as `body` is found. @default true */
 	waitForDomReady?: false;
 
-	/** Whether to re-run `init` on pages loaded via AJAX. @default true */
-	repeatOnAjax?: false;
-
 	/** When pressing the back button, the DOM and listeners are still there, so normally `init` isn’t called again. If this is true, it’s called anyway.  @default false */
-	repeatOnAjaxEvenOnBackButton?: true;
+	repeatOnBackButton?: true;
 
 	/** When true, don’t run the `init` on page load but only add the `additionalListeners`. @default false */
 	onlyAdditionalListeners?: true;
@@ -206,9 +203,8 @@ const add = async (meta?: FeatureMeta, ...loaders: FeatureLoader[]): Promise<voi
 			exclude = [], // Default: nothing
 			init,
 			deinit,
-			repeatOnAjax = true,
 			waitForDomReady = true,
-			repeatOnAjaxEvenOnBackButton = false,
+			repeatOnBackButton = false,
 			onlyAdditionalListeners = false,
 			additionalListeners = []
 		} = loader;
@@ -230,13 +226,11 @@ const add = async (meta?: FeatureMeta, ...loaders: FeatureLoader[]): Promise<voi
 			void setupPageLoad(id, details);
 		}
 
-		if (repeatOnAjax) {
-			document.addEventListener('pjax:end', () => {
-				if (repeatOnAjaxEvenOnBackButton || !select.exists('has-rgh')) {
-					void setupPageLoad(id, details);
-				}
-			});
-		}
+		document.addEventListener('pjax:end', () => {
+			if (repeatOnBackButton || !select.exists('has-rgh')) {
+				void setupPageLoad(id, details);
+			}
+		});
 	}
 };
 

diff --git a/source/features/infinite-scroll.tsx b/source/features/infinite-scroll.tsx
@@ -1,4 +1,5 @@
 import select from 'select-dom';
+import onetime from 'onetime';
 import debounce from 'debounce-fn';
 import * as pageDetect from 'github-url-detection';
 
@@ -65,6 +66,5 @@ void features.add({
 		pageDetect.isDashboard
 	],
 	onlyAdditionalListeners: true,
-	repeatOnAjax: false,
-	init
+	init: onetime(init)
 });
diff --git a/source/features/linkify-labels-on-dashboard.tsx b/source/features/linkify-labels-on-dashboard.tsx
@@ -1,5 +1,6 @@
 import React from 'dom-chef';
 import select from 'select-dom';
+import onetime from 'onetime';
 import * as pageDetect from 'github-url-detection';
 
 import {wrap} from '../helpers/dom-utils';
@@ -26,6 +27,5 @@ void features.add({
 		pageDetect.isDashboard
 	],
 	onlyAdditionalListeners: true,
-	repeatOnAjax: false,
-	init
+	init: onetime(init)
 });
diff --git a/source/features/linkify-user-edit-history-popup.tsx b/source/features/linkify-user-edit-history-popup.tsx
@@ -1,4 +1,5 @@
 import React from 'dom-chef';
+import onetime from 'onetime';
 import {observe} from 'selector-observer';
 import * as pageDetect from 'github-url-detection';
 
@@ -24,10 +25,9 @@ void features.add({
 	description: 'Linkifies the username in the edit history popup.',
 	screenshot: 'https://user-images.githubusercontent.com/1402241/88917988-9ebb7480-d260-11ea-8690-0a3440f1ebbc.png'
 }, {
-	init,
 	include: [
 		pageDetect.isIssue,
 		pageDetect.isPRConversation
 	],
-	repeatOnAjax: false
+	init: onetime(init)
 });
diff --git a/source/features/monospace-textareas.tsx b/source/features/monospace-textareas.tsx
@@ -1,4 +1,6 @@
 import './monospace-textareas.css';
+import onetime from 'onetime';
+
 import features from '.';
 
 function init(): void {
@@ -11,6 +13,5 @@ void features.add({
 	screenshot: false
 }, {
 	waitForDomReady: false,
-	repeatOnAjax: false,
-	init
+	init: onetime(init)
 });
diff --git a/source/features/one-key-formatting.tsx b/source/features/one-key-formatting.tsx
@@ -1,3 +1,4 @@
+import onetime from 'onetime';
 import delegate from 'delegate-it';
 import * as pageDetect from 'github-url-detection';
 import * as textFieldEdit from 'text-field-edit';
@@ -42,6 +43,5 @@ void features.add({
 		pageDetect.hasCode
 	],
 	waitForDomReady: false,
-	repeatOnAjax: false,
-	init
+	init: onetime(init)
 });
diff --git a/source/features/open-issue-to-latest-comment.tsx b/source/features/open-issue-to-latest-comment.tsx
@@ -1,5 +1,6 @@
 import React from 'dom-chef';
 import select from 'select-dom';
+import onetime from 'onetime';
 import * as pageDetect from 'github-url-detection';
 
 import features from '.';
@@ -34,6 +35,5 @@ void features.add({
 		pageDetect.isDashboard
 	],
 	onlyAdditionalListeners: true,
-	repeatOnAjax: false,
-	init: initDashboard
+	init: onetime(initDashboard)
 });
diff --git a/source/features/parse-backticks.tsx b/source/features/parse-backticks.tsx
@@ -1,4 +1,5 @@
 import './parse-backticks.css';
+import onetime from 'onetime';
 import {observe} from 'selector-observer';
 
 import features from '.';
@@ -47,6 +48,5 @@ void features.add({
 	description: 'Renders text in `backticks` in issue titles, commit titles and more places.',
 	screenshot: 'https://user-images.githubusercontent.com/170270/55060505-31179b00-50a4-11e9-99a9-c3691ba38d66.png'
 }, {
-	init,
-	repeatOnAjax: false
+	init: onetime(init)
 });
diff --git a/source/features/profile-hotkey.tsx b/source/features/profile-hotkey.tsx
@@ -1,4 +1,5 @@
 import select from 'select-dom';
+import onetime from 'onetime';
 
 import features from '.';
 import {getUsername} from '../github-helpers';
@@ -20,6 +21,5 @@ void features.add({
 		'g m': 'Go to Profile'
 	}
 }, {
-	repeatOnAjax: false,
-	init
+	init: onetime(init)
 });
diff --git a/source/features/recently-pushed-branches-enhancements.tsx b/source/features/recently-pushed-branches-enhancements.tsx
@@ -1,6 +1,7 @@
 import './recently-pushed-branches-enhancements.css';
 import React from 'dom-chef';
 import select from 'select-dom';
+import onetime from 'onetime';
 import * as pageDetect from 'github-url-detection';
 
 import features from '.';
@@ -59,8 +60,7 @@ void features.add({
 	include: [
 		pageDetect.isRepo
 	],
-	repeatOnAjax: false,
-	init
+	init: onetime(init)
 }, {
 	include: [
 		pageDetect.isRepo

diff --git a/source/features/remove-projects-tab.tsx b/source/features/remove-projects-tab.tsx
@@ -1,5 +1,6 @@
 import React from 'dom-chef';
 import select from 'select-dom';
+import onetime from 'onetime';
 import elementReady from 'element-ready';
 import * as pageDetect from 'github-url-detection';
 
@@ -82,7 +83,6 @@ void features.add({
 		pageDetect.isRepo,
 		pageDetect.isOrganizationProfile
 	],
-	repeatOnAjax: false,
 	waitForDomReady: false,
-	init: addNewProjectLink
+	init: onetime(addNewProjectLink)
 });
diff --git a/source/features/selection-in-new-tab.tsx b/source/features/selection-in-new-tab.tsx
@@ -1,4 +1,5 @@
 import select from 'select-dom';
+import onetime from 'onetime';
 
 import features from '.';
 import {isEditable} from '../helpers/dom-utils';
@@ -28,6 +29,5 @@ void features.add({
 	}
 }, {
 	waitForDomReady: false,
-	repeatOnAjax: false,
-	init
+	init: onetime(init)
 });