Merged
Conversation
fregante
reviewed
Aug 6, 2020
| const cancelButton = select<HTMLButtonElement>([ | ||
| '.js-hide-inline-comment-form', | ||
| '.js-comment-cancel-button' | ||
| ], field.form!); |
Member
There was a problem hiding this comment.
The only reason to do this is to add comments. If comments aren’t there or aren’t necessary, there’s no need to do this.
fregante
reviewed
Aug 6, 2020
fregante
reviewed
Aug 6, 2020
| const comments = select.all([ | ||
| ':not(.js-new-comment-form):not([id^="pullrequestreview"]) > .timeline-comment:not(.rgh-time-machine-links)', | ||
| '.review-comment > .previewable-edit:not(.is-pending):not(.rgh-time-machine-links)' | ||
| ]); |
Member
There was a problem hiding this comment.
Does this need to be commented? Can you add comments if they help?
Member
Author
There was a problem hiding this comment.
Comments wont help much. I think the classes are self explanatory
yakov116
commented
Aug 7, 2020
Member
|
Can you also fix the capitalization here? sindresorhus/onetime#12 |
Let refined-github#3451 update it, to avoid conflicts
Member
Author
|
@fregante you can merge. I am going on vacation for a week starting tomorrow. and will have very limited access |
Member
|
Enjoy! |
Member
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to popular demand I have opened another lint PR. #3412 (comment)
I changed the select.all's to (almost) always be an array. Its easier to read IMHO and gives the ability to add comments.