Add prevent-duplicate-pr-submission feature
#3433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
requested changes
Aug 5, 2020
Member
There was a problem hiding this comment.
There's a problem with disabling buttons on submit:
- if I quickly press esc after submitting (to attempt cancelling the submission) a disabled button won't let me re-try
- if the submission fails and the browser displays the "no connection" page, when pressing "back" the form will still be disabled
I think, perhaps, the safest way to handle this is to just block quick sequential submissions via events, like:
on submit
if (Date.now() - previousSubmission < 1000)
preventDefault()
previousSubmission = Date.now()
fregante
changed the title
prevent-duplicate-pull-request-submission featureprevent-duplicate-pr-submission feature
Member
Author
|
What I committed works. I am not sure why but if I listed to the submit event it does not work. What should the screenshot be of? |
fregante
reviewed
Aug 6, 2020
Co-authored-by: Federico <opensource@bfred.it>
fregante
reviewed
Aug 6, 2020
fregante
reviewed
Aug 6, 2020
Co-authored-by: Federico <opensource@bfred.it>
fregante
reviewed
Aug 6, 2020
Co-authored-by: Federico <opensource@bfred.it>
yakov116
commented
Aug 6, 2020
Merged
fregante
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LINKED ISSUES:
Closes Prevent accidentally creating duplicate pull requests #3398
TEST URLS:
Create a new PR
SCREENSHOT:
