Small fix to show-open-prs-of-forks
#3432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
reviewed
Aug 4, 2020
|
|
||
| async function getPRs(): Promise<[number, string] | []> { | ||
| await elementReady('.repohead + *'); // Wait for the tab bar to be loaded | ||
| await elementReady('.pagehead + *, .UnderlineNav-body + *'); // Wait for the tab bar to be loaded |
Member
There was a problem hiding this comment.
Why does this also change repohead? Isn't that part just for GHE now?
Member
Author
There was a problem hiding this comment.
We need to wait for bar to load. Repohead does not exist anymore.
Member
Author
There was a problem hiding this comment.
Isn't that part just for GHE now?
I dont remember I copied from bug-tab
Member
Author
There was a problem hiding this comment.
This exists in GHE with the new selector. If there are specific concerns, @ me and I can check.
Originally posted by @busches in https://github.com/_render_node/MDIzOlB1bGxSZXF1ZXN0UmV2aWV3VGhyZWFkMjg0NzQwMzA4OnYy/pull_request_review_threads/discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates selectors.
Also fixes the
cacheKey. The repo url was not saved so if you had more than one fork it would show on both.