Skip to content

Fixes and improvements to useful-not-found-page #3430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fregante merged 1 commit into from
Aug 3, 2020
Merged

Fixes and improvements to useful-not-found-page #3430

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions source/features/useful-not-found-page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ async function addDefaultBranchLink(bar: Element): Promise<void> {

bar.after(
<p className="container mt-4 text-center">
See also the file on the <a href={url}>default branch</a>
See also the object on the <a href={url}>default branch</a>
</p>
);
}
Expand All @@ -82,8 +82,8 @@ function init(): false | void {
const bar = <h2 className="container mt-4 text-center"/>;

for (const [i, part] of parts.entries()) {
if (i === 2 && part === 'tree') {
// `/tree/` is not a real part of the URL
if (i === 2 && ['tree', 'blob', 'edit'].includes(part)) {
// Exclude parts that don't exist as standalones
continue;
}

Expand All @@ -103,8 +103,14 @@ function init(): false | void {
void checkAnchor(bar.children[i] as HTMLAnchorElement);
}

if (parts[2] === 'tree') {
if (parts[2] === 'tree' || parts[2] === 'blob') {
// Object might be 410 Gone
void addCommitHistoryLink(bar);
}

if (parts[2] === 'edit') {
// File might not be available on the current branch
// GitHub already redirects /tree/ and /blob/ natively
void addDefaultBranchLink(bar);
}
}
Expand Down