Skip to content

Fixes and improvements to useful-not-found-page#3430

Merged
fregante merged 1 commit intomasterfrom
more-useful-not-found
Aug 3, 2020
Merged

Fixes and improvements to useful-not-found-page#3430
fregante merged 1 commit intomasterfrom
more-useful-not-found

Conversation

@fregante
Copy link
Member

@fregante fregante commented Aug 3, 2020

GitHub seems to have finally started automatically redirecting URLs to old branches:

Screen Shot 2020-08-03 at 19 24 49

Demo:

So I'm removing this behavior from blob and tree


However, they don't apply this behavior to edit URLs, so I'm leaving the logic just for that:


Bugfixes:


Original feature tests in #1558

@fregante
Copy link
Member Author

fregante commented Aug 3, 2020

@yakov116 how come this feature was not switched over to GitHubURL? Did it not work?

@yakov116
Copy link
Member

yakov116 commented Aug 3, 2020

CurrentBranch does not exist

@fregante
Copy link
Member Author

fregante commented Aug 3, 2020

Does that make it crash altogether?

@fregante fregante merged commit 6cfbfd4 into master Aug 3, 2020
@fregante fregante deleted the more-useful-not-found branch August 3, 2020 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants