Skip to content

Add isNewIssue to tab-to-indent #3419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yakov116 wants to merge 3 commits into from
Closed

Add isNewIssue to tab-to-indent #3419

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d3b2ec0
Add `isNewIssue` to `tab-to-indent`
yakov116 Jul 31, 2020
4a165e6
Update source/features/tab-to-indent.tsx
yakov116 Jul 31, 2020
6a7ec85
Update source/features/tab-to-indent.tsx
yakov116 Jul 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion source/features/tab-to-indent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ void features.add({
screenshot: 'https://user-images.githubusercontent.com/1402241/33802977-beb8497c-ddbf-11e7-899c-698d89298de4.gif'
}, {
include: [
pageDetect.hasCode
pageDetect.hasCode,
Copy link
Member

@fregante fregante Jul 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think hasCode is necessary anymore

Suggested change
pageDetect.hasCode,

Copy link
Member Author

@yakov116 yakov116 Jul 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is code is needed for editing files etc.. But my first commit was correct. Not the second. Since all hasRichTextEditor adds is isNewIssue

Copy link
Member

@fregante fregante Aug 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editing files don’t use the rich text editor

pageDetect.isNewIssue
],
waitForDomReady: false,
repeatOnAjax: false,
Expand Down