Skip to content

Add isNewIssue to tab-to-indent#3419

Closed
yakov116 wants to merge 3 commits intorefined-github:masterfrom
yakov116:pagedetect
Closed

Add isNewIssue to tab-to-indent#3419
yakov116 wants to merge 3 commits intorefined-github:masterfrom
yakov116:pagedetect

Conversation

@yakov116
Copy link
Member

  1. LINKED ISSUES:
    Closes Support editor indent/deintent in new-issue editor #3414

  2. TEST URLS:
    https://github.com/sindresorhus/refined-github/issues/new

  3. SCREENSHOT:
    Add a screenshot here if your PR makes visual changes

@yakov116 yakov116 changed the title Add isNewIssue to tab-to-indent Add hasRichTextEditor to tab-to-indent Jul 31, 2020
}, {
include: [
pageDetect.hasCode
pageDetect.hasCode,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think hasCode is necessary anymore

Suggested change
pageDetect.hasCode,

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is code is needed for editing files etc.. But my first commit was correct. Not the second. Since all hasRichTextEditor adds is isNewIssue

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editing files don’t use the rich text editor

@fregante fregante added the bug label Jul 31, 2020
@yakov116 yakov116 changed the title Add hasRichTextEditor to tab-to-indent Add isNewIssue to tab-to-indent Jul 31, 2020
@fregante fregante closed this in be7c091 Aug 1, 2020
@yakov116 yakov116 deleted the pagedetect branch August 3, 2020 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

Support editor indent/deintent in new-issue editor

2 participants